Merge pull request #1480 from aleho/master

Use explicit nullables types
dustin10 · Nov 29, 2024 · 5bbfcb1 · 5bbfcb1
2 parents 7925bea + 4fad8e4
commit 5bbfcb1
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 7 deletions.
diff --git a/src/Exception/MissingPackageException.php b/src/Exception/MissingPackageException.php
@@ -4,7 +4,7 @@
 
 final class MissingPackageException extends \RuntimeException implements VichUploaderExceptionInterface
 {
-    public function __construct(string $message = '', \Throwable $previous = null)
+    public function __construct(string $message = '', ?\Throwable $previous = null)
     {
         parent::__construct($message, 0, $previous);
     }

diff --git a/src/Form/Type/VichFileType.php b/src/Form/Type/VichFileType.php
@@ -31,7 +31,7 @@ public function __construct(
         protected readonly StorageInterface $storage,
         protected readonly UploadHandler $handler,
         protected readonly PropertyMappingFactory $factory,
-        PropertyAccessorInterface $propertyAccessor = null
+        ?PropertyAccessorInterface $propertyAccessor = null
     ) {
         $this->propertyAccessor = $propertyAccessor ?: PropertyAccess::createPropertyAccessor();
     }

diff --git a/src/Form/Type/VichImageType.php b/src/Form/Type/VichImageType.php
@@ -29,7 +29,7 @@ public function __construct(
         StorageInterface $storage,
         UploadHandler $handler,
         PropertyMappingFactory $factory,
-        PropertyAccessorInterface $propertyAccessor = null,
+        ?PropertyAccessorInterface $propertyAccessor = null,
         private readonly ?CacheManager $cacheManager = null
     ) {
         parent::__construct($storage, $handler, $factory, $propertyAccessor);

diff --git a/src/Handler/DownloadHandler.php b/src/Handler/DownloadHandler.php
@@ -21,7 +21,7 @@ final class DownloadHandler extends AbstractHandler
      * @throws NoFileFoundException
      * @throws \InvalidArgumentException
      */
-    public function downloadObject(object|array $object, string $field, ?string $className = null, string|bool $fileName = null, bool $forceDownload = true): StreamedResponse
+    public function downloadObject(object|array $object, string $field, ?string $className = null, string|bool|null $fileName = null, bool $forceDownload = true): StreamedResponse
     {
         $mapping = $this->getMapping($object, $field, $className);
         $stream = $this->storage->resolveStream($object, $field, $className);

diff --git a/src/Metadata/CacheWarmer.php b/src/Metadata/CacheWarmer.php
@@ -13,7 +13,7 @@ public function __construct(private readonly string $dir, private readonly Metad
     {
     }
 
-    public function warmUp(string $cacheDir, string $buildDir = null): array
+    public function warmUp(string $cacheDir, ?string $buildDir = null): array
     {
         if (empty($this->dir)) {
             return [];

diff --git a/src/Metadata/Driver/AbstractYamlDriver.php b/src/Metadata/Driver/AbstractYamlDriver.php
@@ -49,7 +49,7 @@ protected function loadMappingFile(string $file)
         return YmlParser::parse(\file_get_contents($file));
     }
 
-    protected function guessClassName(string $file, array $config, \ReflectionClass $class = null): string
+    protected function guessClassName(string $file, array $config, ?\ReflectionClass $class = null): string
     {
         if (null === $class) {
             return \current(\array_keys($config));

diff --git a/src/Metadata/Driver/XmlDriver.php b/src/Metadata/Driver/XmlDriver.php
@@ -48,7 +48,7 @@ protected function getExtension(): string
         return 'xml';
     }
 
-    protected function guessClassName(string $file, \SimpleXMLElement $elem, \ReflectionClass $class = null): string
+    protected function guessClassName(string $file, \SimpleXMLElement $elem, ?\ReflectionClass $class = null): string
     {
         if (null === $class) {
             return (string) $elem->attributes()->class;