Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optimism velodrome v2 concentrated liquidity pool #7038

Merged

Conversation

0xdatawolf001
Copy link
Contributor

Thank you for contributing to Spellbook 🪄

Update!

Please build spells in the proper subproject directory. For more information, please see the main readme, which also links to a GH discussion with the option to ask questions.

Contribution type

Please check the type of contribution this pull request is for:

  • New spell(s)
  • [X ] Adding to existing spell lineage
  • Bug fix

For adding to existing spell lineage

let me know if something is not right!

@0xdatawolf001
Copy link
Contributor Author

How can i fix this? Was looking into the uniswap v3 macro and fee is optional. Also, the other ctes in the base script don't have a fee column.

@Hosuke Hosuke self-assigned this Oct 26, 2024
Copy link
Collaborator

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hosuke Hosuke added in review Assignee is currently reviewing the PR dbt: dex covers the DEX dbt subproject labels Oct 26, 2024
@0xdatawolf001
Copy link
Contributor Author

0xdatawolf001 commented Nov 2, 2024

sorry for the delay! Here are the required changes. Just curious, is it possible to test this? I'm trying the test table. Maybe i'm botching the table name

Copy link
Collaborator

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.✅
Thank you @0xdatawolf001

Sample 2_cl velodrome trades

You can test the data using above query by the way.

@Hosuke Hosuke added ready-for-final-review and removed in review Assignee is currently reviewing the PR labels Nov 2, 2024
@Hosuke Hosuke assigned jeff-dude and unassigned Hosuke Nov 2, 2024
@jeff-dude jeff-dude merged commit 76000f5 into duneanalytics:main Nov 6, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2024
@0xdatawolf001 0xdatawolf001 deleted the velodromeV2CL-dexTrades-6828 branch November 6, 2024 10:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: dex covers the DEX dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants