Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Enable Malicious Site Protection on macOS" #2624

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kdzwinel
Copy link
Member

@kdzwinel kdzwinel commented Jan 7, 2025

Reverts #2623 and disables Malicious Site Protection for macOS users

@kdzwinel kdzwinel added the DO NOT MERGE Don't merge this branch unless directed label Jan 7, 2025
@kdzwinel kdzwinel requested review from a team as code owners January 7, 2025 20:05
Copy link

github-actions bot commented Jan 7, 2025

Don't forget to assign an individual reviewer (in addition to those already added, this should create a task for them in Asana).
Please mark this as draft unless there's intention to merge this.
Click the "Merge When Ready" if you're happy for this to automatically get merged once reviewed.
Also don't forget to add schema changes to validate if you're adding/changing a feature.

Copy link

github-actions bot commented Jan 7, 2025

Generated file outputs:

Time updated: Tue, 07 Jan 2025 20:05:43 GMT

legacy
trackers-unprotected-temporary.txt (13 more)
  • trackers-unprotected-temporary.txt
  • v3/android-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/windows-config.json

⚠️ File is identical

v3/macos-config.json
--- v3/macos-config.json
+++ v3/macos-config.json
@@ -6525,9 +6525,9 @@
             },
             "exceptions": []
         },
         "maliciousSiteProtection": {
-            "state": "enabled",
+            "state": "internal",
             "exceptions": [
                 {
                     "domain": "broken.third-party.site",
                     "reason": "A test page that helps us verify if exceptions work correctly."
latest
v4/android-config.json (12 more)
  • v4/android-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/windows-config.json

⚠️ File is identical

v4/macos-config.json
--- v4/macos-config.json
+++ v4/macos-config.json
@@ -5952,9 +5952,9 @@
             },
             "exceptions": []
         },
         "maliciousSiteProtection": {
-            "state": "enabled",
+            "state": "internal",
             "exceptions": [
                 {
                     "domain": "broken.third-party.site"
                 }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Don't merge this branch unless directed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants