Update to AutofillCredentialIdentityStoreManager for lazy vault initialisation #3763
+21
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…provide a vault (and always provide SecureVaultReporter() since AutofillCredentialIdentityStoreManager can now init the vault lazily)
quanganhdo
approved these changes
Jan 7, 2025
…er-vault-init # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
amddg44
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Jan 8, 2025
…itialised lazily (#1145) Task/Issue URL: https://app.asana.com/0/414709148257752/1209045090157949/f iOS PR: duckduckgo/iOS#3763 macOS PR: duckduckgo/macos-browser#3702 What kind of version bump will this require?: Minor **Description**: Update to vault initialization in AutofillCredentialIdentityStoreManager to only init on demand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414709148257752/1209045090157949/f
Tech Design URL:
CC:
Description:
Fixes an occasional crash in SyncCredentialsAdapter due to vault being initialised unnecessarily early for AutofillCredentialIdentityStoreManager in the app startup flow
Steps to test this PR:
Definition of Done (Internal Only):
Copy Testing:
’rather than’Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
—
Internal references:
Software Engineering Expectations
Technical Design Template