Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alessandro/refresh dax dialog and ntp logo #3129

Conversation

SabrinaTardio
Copy link
Contributor

@SabrinaTardio SabrinaTardio commented Jul 24, 2024

Task/Issue URL: https://app.asana.com/0/1206329551987282/1207874379831572/f

Description:

Implements logic for showing the same dialog on refresh and restore the dax dialog when the app re-launch.

Steps to test this PR:
1.
2.

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@alessandroboron alessandroboron force-pushed the alessandro/refresh-dax-dialog-and-ntp-logo branch from 84e4002 to 28f95ed Compare July 24, 2024 08:57
Copy link

github-actions bot commented Jul 24, 2024

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against a5dea37

@alessandroboron alessandroboron force-pushed the alessandro/refresh-dax-dialog-and-ntp-logo branch from 28f95ed to a5dea37 Compare July 25, 2024 00:29
Copy link

🚫 The Asana task linked in the PR description is not added to iOS App Board project.

  1. Verify that the correct task is linked in the PR.
    • ⚠️ Please use the actual implementation task, rather than the Code Review subtask.
  2. Verify that the task is added to iOS App Board project.
  3. When ready, remove the bot: not in app board label to retrigger the check.

@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Jul 25, 2024
@alessandroboron alessandroboron merged commit f9a2798 into AleSab/implement-contextual-onboarding Jul 25, 2024
19 of 20 checks passed
@alessandroboron alessandroboron deleted the alessandro/refresh-dax-dialog-and-ntp-logo branch July 25, 2024 00:45
alessandroboron added a commit that referenced this pull request Jul 25, 2024
alessandroboron added a commit that referenced this pull request Jul 29, 2024
alessandroboron added a commit that referenced this pull request Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants