New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use search term as title for search related history items in suggestions #2982

Merged

brindy merged 1 commit into main from brindy/clean-up-search-title-in-suggestions

Jun 24, 2024

Contributor

brindy commented Jun 21, 2024

Task/Issue URL: https://app.asana.com/0/392891325557410/1207625167306167/f
Tech Design URL:
CC:

Description:
Just use the search term as the title for search history and explode switch to be more explicit.

Steps to test this PR:

Ensure recently visited sites enabled (internal user and setting enabled)
Perform a search
Type search into field again -> should show the search term only as the history item title with 'search DuckDuckGo' as the subtitle
Visit a page
Ensure that page appears in history
Check that bookmarks and favorites appear as such in suggestions


          just use the search term as the title for search history and explode …

2358bed

…switch to be more explicit

samsymons self-requested a review

June 23, 2024 19:42

samsymons approved these changes

View reviewed changes

Contributor

samsymons left a comment

Worked for me, and a general smoke test of autocomplete didn't show any new issues.

brindy merged commit 64d0df9 into main

19 checks passed

brindy deleted the brindy/clean-up-search-title-in-suggestions branch

June 24, 2024 06:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet