Undo ship review config hacks

duckduckgo · Jul 22, 2024 · 973c5d1 · 973c5d1
1 parent b6143ac
commit 973c5d1
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 10 deletions.
diff --git a/Core/AppURLs.swift b/Core/AppURLs.swift
@@ -42,8 +42,7 @@ public extension URL {
 
     // The following URLs shall match the ones in update_embedded.sh. 
     // Danger checks that the URLs match on every PR. If the code changes, the regex that Danger uses may need an update.
-    static let privacyConfig = URL(string: "https://jsonblob.com/api/1262834058273873920")!
-//    static let privacyConfig = URL(string: "\(staticBase)/trackerblocking/config/v4/ios-config.json")!
+    static let privacyConfig = URL(string: "\(staticBase)/trackerblocking/config/v4/ios-config.json")!
     static let trackerDataSet = URL(string: "\(staticBase)/trackerblocking/v5/current/ios-tds.json")!
     static let bloomFilter = URL(string: "\(staticBase)/https/https-mobile-v2-bloom.bin")!
     static let bloomFilterSpec = URL(string: "\(staticBase)/https/https-mobile-v2-bloom-spec.json")!

diff --git a/Core/ios-config.json b/Core/ios-config.json
@@ -414,13 +414,6 @@
             },
             "hash": "bd604dcd1f7bb584185f0c1cb94a5771"
         },
-        "autofillBreakageReporter": {
-            "state": "enabled",
-            "settings": {
-                "monitorIntervalDays": 42
-            },
-            "exceptions": []
-        },
         "brokenSiteReportExperiment": {
             "exceptions": [],
             "state": "enabled",

diff --git a/DuckDuckGo/AutofillLoginListViewModel.swift b/DuckDuckGo/AutofillLoginListViewModel.swift
@@ -521,7 +521,7 @@ final class AutofillLoginListViewModel: ObservableObject {
     func shouldShowBreakageReporter() -> Bool {
         guard let currentTabUrl = currentTabUrl,
               !accountsToSuggest.isEmpty,
-              privacyConfig.isEnabled(featureKey: .autofill),
+              privacyConfig.isEnabled(featureKey: .autofillBreakageReporter),
               let identifier = currentTabUrl.privacySafeDomainIdentifier,
               !privacyConfig.isInExceptionList(domain: currentTabUrl.host, forFeature: .autofillBreakageReporter) else {
             return false