Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Chrome Counteract Exp code #2284

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Remove Chrome Counteract Exp code #2284

merged 1 commit into from
Oct 24, 2023

Conversation

moollaza
Copy link
Member

Reviewer:
@jonathanKingston

Description:

Removes code added in #2145, #2160,

Steps to test this PR:

  • Close any tabs for duckduckgo.com
  • Build + install extension
  • Post-install page (/extension-success) should open
  • Confirm that no ATB letters are part of the atb= value

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

@moollaza moollaza self-assigned this Oct 20, 2023
@moollaza moollaza marked this pull request as ready for review October 20, 2023 19:52
@Szigeticsilla Szigeticsilla mentioned this pull request Oct 23, 2023
Closed
@sammacbeth sammacbeth merged commit 556382f into main Oct 24, 2023
15 of 17 checks passed
@moollaza moollaza deleted the zaahir/remove-counteract-exp branch October 24, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sammacbeth sammacbeth sammacbeth approved these changes

@jonathanKingston jonathanKingston Awaiting requested review from jonathanKingston

Assignees

@moollaza moollaza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moollaza @sammacbeth