Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ntp: support multiple release-note lists #1385

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Jan 10, 2025

Asana Task/Github Issue: https://app.asana.com/0/1207414201589134/1209114169882239/f

Description

  • Support for separate lists - this is a temporary measure until windows supports the shared releases notes.

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Copy link

netlify bot commented Jan 10, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 2f0045f
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/678151f478d5ed000886defb
😎 Deploy Preview https://deploy-preview-1385--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shakyShane
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Jan 10, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Jan 10, 2025

[Beta] Generated file diff

Time updated: Fri, 10 Jan 2025 17:04:18 GMT

Integration
    - integration/pages/new-tab/dist/index.css
  • integration/pages/new-tab/dist/index.js

File has changed

Windows
    - windows/pages/new-tab/dist/index.css
  • windows/pages/new-tab/dist/index.js

File has changed

Apple
    - dist/pages/new-tab/dist/index.css
  • dist/pages/new-tab/dist/index.js

File has changed

@shakyShane shakyShane marked this pull request as ready for review January 10, 2025 17:03
@shakyShane shakyShane requested review from mgurgel and a team as code owners January 10, 2025 17:03
Copy link
Contributor

@mgurgel mgurgel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants