Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix threading issue with Mesage broker #908

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

afterxleep
Copy link
Collaborator

@afterxleep afterxleep commented Jul 24, 2024

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/1204099484721401/1207878727316917/f
iOS PR: duckduckgo/iOS#3132
macOS PR: duckduckgo/macos-browser#3013
What kind of version bump will this require?: Patch

Description:

  • Moves Message broker methods to main thread

Steps to test this PR:

  1. CI should be 🥬

@afterxleep afterxleep changed the title Moves evaluateJS methods to main thread Fix threading issue with Mesage broker Jul 24, 2024
Copy link
Contributor

@SabrinaTardio SabrinaTardio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@afterxleep afterxleep merged commit 6c095d0 into main Jul 24, 2024
14 of 16 checks passed
@afterxleep afterxleep deleted the daniel/broker.async branch July 24, 2024 15:07
afterxleep added a commit to duckduckgo/macos-browser that referenced this pull request Jul 24, 2024
Task/Issue URL: https://app.asana.com/0/414235014887631/1207878727316917/f
BSK PR: duckduckgo/BrowserServicesKit#908

Description:
Bumps BSK whit a fix for message broker
afterxleep added a commit to duckduckgo/iOS that referenced this pull request Jul 24, 2024
samsymons added a commit that referenced this pull request Jul 25, 2024
* main:
  Moves evaluateJS methods to main thread (#908)
  Bumped C-S-S to 6.4.0 (#910)
  Don't show key icon for empty passwords (#890)
  Hotfix: fix index out-of-bounds in startAttachingCrashLogMessages (#906)
  Add support for additionalCampaignPixelParams (#899)
  Update breakage report locale to JSON format (#905)
  Add support for additionalCampaignPixelParams
quanganhdo pushed a commit to duckduckgo/macos-browser that referenced this pull request Jul 31, 2024
Task/Issue URL: https://app.asana.com/0/414235014887631/1207878727316917/f
BSK PR: duckduckgo/BrowserServicesKit#908

Description:
Bumps BSK whit a fix for message broker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants