-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Hypixel translations. #2
base: dev
Are you sure you want to change the base?
Conversation
…ile. ChatEvent: - Change HashMaps to be static as the translations will not change mid-game. - Change the event handlers to be static as we're only accessing static information. Config: - Add a final translation field for Gson to deserialize to. Main: - Load the `languages.json` file from the jar's resources. - Deserialize it to the `Config` class - Populate the translation classes on startup for fast lookups. - Change event handlers to be static.
…orrectly named file and version
Add turkish translation
…ries; Added all of Hypixel's translations. Closes dubfib#1
I'll run tests on this just to make sure it works on your branch, although it looks very good at first glance. (could expect this test around tomorrow - few days) edit: so um, looked at the json file and there is a problem.. "goodLuckTranslations": [
"The game starts in 2 seconds!", this is fine as everyone can see this ^^ "goodGameTranslations": [
"This game has been recorded. Click here to watch the Replay!", im pretty sure this requires you to have a rank in order to access replay ^^ |
Oh, yeah that's an issue. I decided to go with the replay route since it appeared in most Hypixel games, not just Bedwars and Skywars. Additionally at a glance, I couldn't find a consistent message that was across all/most games telling the user that the game had ended... Except for the replay message. I'll go through and check again in the console, maybe there's a Regex pattern I could create. Oh but that means I'll have to go through all 20+ languages again... Arghhh.... |
Adds all of Hypixel's translations. Minor project restructure. Closes #1