Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Hypixel translations. #2

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

Added Hypixel translations. #2

wants to merge 8 commits into from

Conversation

OoLunar
Copy link

@OoLunar OoLunar commented Jan 18, 2023

Adds all of Hypixel's translations. Minor project restructure. Closes #1

OoLunar and others added 8 commits January 1, 2023 11:18
…ile.

ChatEvent:
  - Change HashMaps to be static as the translations will not change mid-game.
  - Change the event handlers to be static as we're only accessing static information.
Config:
  - Add a final translation field for Gson to deserialize to.
Main:
  - Load the `languages.json` file from the jar's resources.
  - Deserialize it to the `Config` class
  - Populate the translation classes on startup for fast lookups.
  - Change event handlers to be static.
Add turkish translation
…ries; Added all of Hypixel's translations. Closes dubfib#1
@dubfib
Copy link
Owner

dubfib commented Jan 18, 2023

I'll run tests on this just to make sure it works on your branch, although it looks very good at first glance. (could expect this test around tomorrow - few days)

edit: so um, looked at the json file and there is a problem..

    "goodLuckTranslations": [
        "The game starts in 2 seconds!",

this is fine as everyone can see this ^^

    "goodGameTranslations": [
        "This game has been recorded. Click here to watch the Replay!",

im pretty sure this requires you to have a rank in order to access replay ^^
and this is kinda a problem as it requires you to buy a rank, even if it is the lowest tier

@OoLunar
Copy link
Author

OoLunar commented Jan 18, 2023

Oh, yeah that's an issue. I decided to go with the replay route since it appeared in most Hypixel games, not just Bedwars and Skywars. Additionally at a glance, I couldn't find a consistent message that was across all/most games telling the user that the game had ended... Except for the replay message. I'll go through and check again in the console, maybe there's a Regex pattern I could create.

Oh but that means I'll have to go through all 20+ languages again... Arghhh....

@dubfib
Copy link
Owner

dubfib commented Jan 19, 2023

Yeah but there is another route that you could go through, after every game there should be a message that says Reward Summary, just Reward Summary needs to be translated and you just check the message content for that.
image
You could do this but.. I don't know if this appears for every game on hypixel, although I have seen this message in most games but I'm not sure if it is all the games on Hypixel, this should in theory not require players to have the VIP rank or higher as you need replay for that message to appear I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants