bugfix: add tests for workflow return values and fix null handling #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
==========================================
+ Coverage 70.02% 70.05% +0.02%
==========================================
Files 45 45
Lines 1998 2000 +2
Branches 194 195 +1
==========================================
+ Hits 1399 1401 +2
Misses 561 561
Partials 38 38 ☔ View full report in Codecov by Sentry. |
wooln
force-pushed
the
bugfix-workflow-return-value
branch
from
254a47b to
563015e
Compare
wooln
changed the title
wooln
force-pushed
the
bugfix-workflow-return-value
branch
2 times, most recently
from
3a4b89e to
e991c7c
Compare
- Fix null value handling for execute again - Add unit test and sample for different workflow return
wooln
force-pushed
the
bugfix-workflow-return-value
branch
from
e991c7c to
a121932
Compare
catcherwong
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
execute的返回结果null和empty时候，再用同一gid再次发起均没有返回的
result的json字段，既byte长度是0不记录也不区分，这些单测和针对Result是null的处理都是建立在务端这feature基础上。