Optimize dstack-gateway installation time
#2146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the `dstack[gateway]` extra, so that the gateway doesn't install `dstack[server]`. `dstack[gateway]` still has some unnecessary dependencies from BASE_DEPS, but the current optimization is enough for now. Also increase the gateway installation timeout just in case.
r4victor
reviewed
Dec 26, 2024
| @@ -11,7 +11,7 @@ requires-python = ">=3.10" | |||
| dynamic = ["version"] | |||
| dependencies = [ | |||
| # release builds of dstack-gateway depend on a PyPI version of dstack instead | |||
| "dstack[server] @ https://github.com/dstackai/dstack/archive/refs/heads/master.zip", | |||
| "dstack[gateway] @ https://github.com/dstackai/dstack/archive/refs/heads/master.zip", | |||
There was a problem hiding this comment.
Seems like a fragile solution since there are no tests that run with dstack[gateway].
There was a problem hiding this comment.
I will merge for now and think how we can test it.
Although we also don't test CLI or individual backends without [all], so it is not much more fragile than the existing extras.
r4victor
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
dstack[gateway]extra, so that thegateway doesn't install
dstack[server].dstack[gateway]still has some unnecessarydependencies from BASE_DEPS, but the current
optimization is enough for now.
Also increase the gateway installation timeout
just in case.
#1595