[shim] Implement multi-task state #2078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The shim is now able to process multiple tasks at a time. The global state for the existing "legacy" API is emulated. From the API caller's point of view, the shim works exactly the same as before. Part-of: #1780
un-def
force-pushed
the
issue_1780_shim_multitask_state
branch
from
3367301 to
dd8e549
Compare
r4victor
reviewed
Dec 11, 2024
| d.containerID = containerID | ||
| d.containerName = cfg.ContainerName | ||
| log.Printf("Running container, name=%s, id=%s\n", d.containerName, containerID) | ||
| log.Printf("Running container, name=%s, id=%s\n", task.containerName, containerID) |
There was a problem hiding this comment.
Have you considered switching to a level-aware logging like logrus used in the runner?
There was a problem hiding this comment.
Not pushing to include it in this PR, but it seems to make sense to do such changes when refactoring.
There was a problem hiding this comment.
Logging facility revamping is in the plans, will be eventually submitted as a separate PR.
r4victor
approved these changes
Dec 11, 2024
jvstme
approved these changes
Dec 11, 2024
jvstme
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shim is now able to process multiple tasks at a time. The global state for the existing "legacy" API is emulated. From the API caller's point of view, the shim works exactly the same as before.
Part-of: #1780