Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]: Move run_async to _internal/utils #2057

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

jvstme
Copy link
Collaborator

@jvstme jvstme commented Dec 4, 2024

Part of an upcoming refactoring in #1595, moved to a separate PR for a smaller diff and to avoid merge conflicts. run_async will be used both in _internal/server and _internal/proxy.

Part of an upcoming refactoring, moved to a
separate PR for a smaller diff and to avoid merge
conflicts. `run_async` will be used both in
`_internal/server` and `_internal/proxy`.
@jvstme jvstme requested a review from r4victor December 4, 2024 12:57
@un-def
Copy link
Collaborator

un-def commented Dec 4, 2024

It would be great to use run_async here too:

await loop.run_in_executor(None, self._remove_log_file)

stderr = await loop.run_in_executor(None, self._read_log_file)

@jvstme jvstme merged commit acf60c9 into master Dec 5, 2024
23 checks passed
@jvstme jvstme deleted the issue_1595_run_async_common_utils branch December 5, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants