-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VMNetworkAdapter: Device Naming and MAC Address Spoofing #208
base: main
Are you sure you want to change the base?
Conversation
Build fails due to dsccommunity/DscResource.DocGenerator#131 |
To whoever owns this module, the build will not work on an Ubuntu worker due to this line:
The error that occurs with every test is similar to this one:
Can we use a Windows build worker for this repository? |
All tests were successful, code coverage could not be uploaded. |
VMNetworkAdapter MAC Spoofing
This reverts commit 4346d6f.
Codecov Report
@@ Coverage Diff @@
## main #208 +/- ##
===================================
+ Coverage 83% 85% +2%
===================================
Files 11 11
Lines 1441 1455 +14
===================================
+ Hits 1203 1245 +42
+ Misses 238 210 -28
|
Apologies in advance for multiple pushes to update my tests, but the local builds fail 8 out of 10 times. |
Pull Request (PR) description
This PR implements the additional parameters DeviceNaming and MacAddressSpoofing to expose more virtual NIC settings.
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed and how that affects users (if applicable), and
reference the issue being resolved (if applicable).
This change is