xVhdFileDirectory Unit Tests #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #180 +/- ##
===================================
Coverage 83% 83%
===================================
Files 11 11
Lines 1401 1401
===================================
Hits 1166 1166
Misses 235 235 |
|
@mcollera or @aromano2 you are listed as maintainers for this module. Do you have time to review this one? |
|
@johlju yes looking at it now, thanks! |
aromano2
approved these changes
Jan 30, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, 1 of 1 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved
johlju
pushed a commit
that referenced
this pull request
Mar 19, 2020
* xVhdFileDirectory initial unit tests added * xVhdFileDirectory unit tests, added GetFreeDriveLetter * Updated CHANGELOG.md * xVhdFileDirectory unit test style fixes * xVhdFileDirectory fixed unit tests for appveyor * xVhdFileDirectory additional unit tests * xVhdFileDirectory unit tests - tidy-up & Get-FreeDrive fix * xVhdFileDirectory unit tests - fixed 'Describe' block description * Merge branch 'dev' into xVhdFileDirectory_UnitTests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
PR that adds some basic initial unit tests for the xVhdFileDirectory resource. There is a bug that I'd like to fix around copying to VHDs with multiple partitions - before I look into that, I'd like to put some unit tests in place.
I have not covered off tests for any of the private functions within the resource as of yet, as I may propose to change a couple.
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is