Updates to handle POSIX extensions #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added note to switch all of these to just using sin and cos together as the preprocessor will handle using sincos if it's available. On systems that don't have the non-compliant extension the use of sincos is a problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two non-standard extensions were used in the code:
IsoTimeStringToDateTimeusesstrptimewhich is a POSIX extension and not C standard. I've informed the preprocessor using the appropriate define.Tsyg2007usedsincos, which is a non-standard extension supplied by glibc (and possibly others). Since the code already had an implementation (mysincos) that was used in a number of places - including all through Tsyg2004 - I've switched the remaining calls to use mysincos.Notes for future:
strptimewon't work on windows (native, not WSL/cygwin) if we want to make sure we can support that we'll need to provide a workaround.mysincosis unnecessary and these calls should be switched to using adjacent calls to sin and cos that the preprocessor can optimize to sincos if it's available.