Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish all generated artifacts to maven central #20

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

eyedol
Copy link
Contributor

@eyedol eyedol commented Oct 2, 2024

It appears we missed the artifacts for iosX64() and iosSimulatorArm64() targets. Only iosArm64() was resolving. In other to support all the artifacts, run the ./gradlew publish to publish all of them to maven central repository.

Also @rharter we will need a public release( if you're ready for a 0.0.3 release) as we're only getting 0.0.3-SNAPSHOT from https://s01.oss.sonatype.org/content/repositories/snapshots/com/dropbox/differ/

cc @takahirom

@eyedol eyedol force-pushed the eyedol/publishAllTargets branch from 8abc10c to f00ad1e Compare October 3, 2024 18:23
Copy link
Collaborator

@rharter rharter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@rharter rharter merged commit 6f81ff3 into dropbox:main Oct 4, 2024
3 checks passed
@rharter
Copy link
Collaborator

rharter commented Oct 4, 2024

Thanks, @eyedol. I wanted to double check that this wasn't reverting some previous changes in here, but from the testing I can do locally without actually releasing it looks good to me.

Since I don't use this in a KMP fashion, would you please validate that the proper artifacts are released in the snapshot to ensure that we're not missing anything that'll require a hotfix release? Then I'll make a proper 0.0.3 release.

@rharter
Copy link
Collaborator

rharter commented Oct 4, 2024

On second thought, this all looks right to me, so I'll go ahead and cut the release.
CleanShot 2024-10-04 at 08 32 40@2x

@eyedol
Copy link
Contributor Author

eyedol commented Oct 4, 2024

On second thought, this all looks right to me, so I'll go ahead and cut the release.

Yes, it has published everything. Thanks for cutting a release for it.

@eyedol eyedol deleted the eyedol/publishAllTargets branch October 4, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants