WIP: Update bintray plugin format for 1.x.x compatibility #25

arcolife · 2019-12-16T14:45:25Z

Add following for new bintray dep:

- json -> yaml: add yaml based config parser
- add forked bintray go client as dep
- godotenv mod to parse configs from .env / env vars all the same

Removed artifactory and will re-add once the above workflow is validated. For this very reason, I'm using a fork of: https://github.com/jfrog/jfrog-client-go -> github.com/arcolife/jfrog-client-go
The fork is waiting to be merged into master at jfrog/jfrog-client-go#103

@tboerger @bradrydzewski A rather delayed follow up from our discussion on gitter earlier at https://gitter.im/drone/plugins?at=5d7fd98572fe125111b77576 😄

Summary https://github.com/arcolife/drone-bintray/blob/update-for-1.x.x/DISCUSSION.md

TODO:

Work out the details of repo config for introducing rest of the functionalities like creation/deletion of Repo, as illustrated under my fork of frog's go client https://github.com/arcolife/jfrog-client-go/blob/bintray-examples/examples/jfrog_client.go
File pattern glob works. Make files array work from the yaml config as well.
Refine format of example package config YAML https://github.com/arcolife/drone-bintray/blob/update-for-1.x.x/package_config.yaml (input for the plugin)
Threads in package_config.yaml here should be 1. So to speak, bintray doesn't accept multiple file uploads in 1 go. Else threads > 1 almost always fails to upload to bintray, the first time jfrog/jfrog-client-go#107

- json -> yaml: add yaml based config parser - add forked bintray go client as dep - godotenv mod to parse configs from .env / env vars all the same - update documentation

tboerger

I haven't reviewed reviewed now,but at least that's a starting point

tboerger · 2019-12-26T16:36:26Z

.env

@@ -0,0 +1,8 @@
+BINTRAY_KEY=f4g8ef@***223


This is only temporary for testing, right?

tboerger · 2019-12-26T16:37:05Z

.gitignore

@@ -2,3 +2,6 @@ release/

 coverage.out
 drone-bintray
+
+*~


This looks like editor specific ignores, you should add that to your local global gitignore.

tboerger · 2019-12-26T16:37:47Z

go.mod

@@ -1,7 +1,12 @@
-module github.com/drone-plugins/drone-bintray
+module github.com/arcolife/drone-bintray


That should be drone-plugins

tboerger · 2019-12-26T16:39:37Z

main.go

+		&cli.IntFlag{
+			Name:    "bintray.threads,t",
+			Usage:   "bintray threads",
+			EnvVars: []string{"PLUGIN_BINTRAY_THREADS", "BINTRAY_THREADS"},


As this is the bintray plugin please name them PLUGIN_ instead of PLUGIN_BINTRAY_

tboerger · 2019-12-26T16:46:29Z

plugin.go

+}
+
+func (config *BintrayConfig) deleteRepo(btManager *bintray.ServicesManager, repo *Repo) error {
+	fmt.Printf("\nDeleting Repo.. [%s]\n", repo.Name)


With all these log messages you should use a structured logger like logrus, we will anyway use it more within plugins as it's part of our upcoming plugin lib

right for some reason logger built in jfrog go library of bintray wasn't working. I was hoping to reuse that tho

tboerger · 2019-12-26T16:48:22Z

plugin.go

+	// 	files []string
+	// )
+	// fmt.Printf("Drone Bintray Plugin built from %s\n", p.Version)
+	cSig := make(chan os.Signal)


We aren't doing that for any plugin and I can't clearly see why we should introduce that here.

add following for new bintray dep:

2aadfd1

- json -> yaml: add yaml based config parser - add forked bintray go client as dep - godotenv mod to parse configs from .env / env vars all the same - update documentation

arcolife force-pushed the update-for-1.x.x branch from aace7e9 to 2aadfd1 Compare December 16, 2019 14:51

tboerger reviewed Dec 26, 2019

View reviewed changes

fix env var issues

8cc8564

arcolife force-pushed the update-for-1.x.x branch from d07b8c6 to 8cc8564 Compare February 10, 2020 14:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: Update bintray plugin format for 1.x.x compatibility #25

WIP: Update bintray plugin format for 1.x.x compatibility #25

arcolife commented Dec 16, 2019 •

edited

Loading

tboerger left a comment

tboerger Dec 26, 2019

arcolife Feb 10, 2020

tboerger Dec 26, 2019

arcolife Feb 10, 2020

tboerger Dec 26, 2019

arcolife Feb 10, 2020

tboerger Dec 26, 2019

arcolife Feb 10, 2020

tboerger Dec 26, 2019

arcolife Feb 10, 2020

tboerger Dec 26, 2019

		@@ -1,7 +1,12 @@
		module github.com/drone-plugins/drone-bintray
		module github.com/arcolife/drone-bintray

WIP: Update bintray plugin format for 1.x.x compatibility #25

Are you sure you want to change the base?

WIP: Update bintray plugin format for 1.x.x compatibility #25

Conversation

arcolife commented Dec 16, 2019 • edited Loading

tboerger left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

arcolife commented Dec 16, 2019 •

edited

Loading