Bytes Reader #77
Bytes Reader #77
Conversation
added a drop method to sequence reader. without it an exception is generated when dealing with byte sequences
Update _reader.py
* Made change to _options basic parser to allow for optional readers * Added a `BytesReader` to the reader module to allow for reading bytes, which makes parsing binary files easier * Made it so that readers inheriting `SequenceReader` can optionally override `drop` and `rest` * Added tests, but I'm not sure where they should go * Added a `rep_n` parser to the `repeated` module, which is like `rep` but takes a number of times to repeat. This was already accomplishable using `min=x, max=x`, but this is a little more readable. added byteparsers
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #77 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 25
Lines 836 890 +54
Branches 100 111 +11
=========================================
+ Hits 836 890 +54
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I used to think that we needed a different This mirrors the complexity where I'm not sure how I feel about |
Offering this up in case you want it. There are a couple of things here that I think are more generally valuable, but I wanted your opinion on them.
Also, I have no idea where the tests should go