Hera/add main layout #1318
Open
Hera/add main layout #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolachr
force-pushed
the
hera/add-main-layout
branch
from
e0f4567 to
ce25368
Compare
caitmich
reviewed
Dec 11, 2024
| </a> | ||
| <ul class="dropdown-menu dropdown-menu-end" aria-labelledby="configurationDropdown"> | ||
| <li><%= link_to 'Configure Integrations', main_app.project_configurations_path(current_project), class: 'dropdown-item' %></li> | ||
| <li><%= link_to "Manage Tags", project_tags_path(current_project), class: 'dropdown-item' %></li> |
There was a problem hiding this comment.
Suggested change
| <li><%= link_to "Manage Tags", project_tags_path(current_project), class: 'dropdown-item' %></li> | |
| <li><%= link_to "Manage Tags", main_app.project_tags_path(current_project), class: 'dropdown-item' %></li> |
There was a problem hiding this comment.
We need this for when we access /validations or /export
caitmich
reviewed
Dec 11, 2024
caitmich
reviewed
Dec 11, 2024
| function submitSearch($form) { | ||
| if ($form.find('[data-behavior~=search-query]').val() !== '') { | ||
| $form.submit(); | ||
| $form.find('[data-behavior~=search-query]').val('Searching...'); |
There was a problem hiding this comment.
I believe this is breaking the search functionality
caitmich
reviewed
Dec 11, 2024
| }); | ||
|
|
||
| $('[data-behavior~=search-query]').on('keypress', function (e) { | ||
| if (e.which === 13) { |
There was a problem hiding this comment.
can we make the magic number a variable like we did with mobileBreakpoint in sidebar.js
caitmich
reviewed
Dec 11, 2024
Comment on lines
+6
to
+8
| <%= require_asset "#{plugin_path}/manifests/tylium" %> | ||
| <%= require_asset "#{plugin_path}/manifests/hera" %> | ||
| <% |
There was a problem hiding this comment.
Suggested change
| <%= require_asset "#{plugin_path}/manifests/tylium" %> | |
| <%= require_asset "#{plugin_path}/manifests/hera" %> | |
| <% | |
| <%= require_asset "#{plugin_path}/manifests/tylium" %> | |
| <%= require_asset "#{plugin_path}/manifests/hera" %> | |
| <% |
caitmich
reviewed
Dec 11, 2024
| @@ -0,0 +1,7 @@ | |||
| class StylesHeraController < AuthenticatedController | |||
There was a problem hiding this comment.
Does this need to be called StylesHereController?
Can we rename it to HeraController instead and have hera/index? or styles/hera/index
There was a problem hiding this comment.
This is carried over from StylesTyliumController. Happy to change this but it's out of scope here.
caitmich
reviewed
Dec 11, 2024
caitmich
reviewed
Dec 11, 2024
| @@ -0,0 +1,71 @@ | |||
| <nav class="navbar navbar-expand-lg project-nav"> | |||
| <div class="container-fluid justify-content-end p-lg-0"> | |||
| <div class="collapse navbar-collapse dual-nav" id="project_navbar" data-behavior="navbar-collapse"> | |||
There was a problem hiding this comment.
Ditto with the id. it's in a different format than the one above, if we need them let's make the case consistent
caitmich
reviewed
Dec 11, 2024
| <% end %> | ||
| </li> | ||
| <li class="nav-item dropdown ms-0"> | ||
| <a href="javascript:void(0)" class="nav-link dropdown-toggle no-caret-xl" id="configurationDropdown" title="Configuration" role="button" data-bs-toggle="dropdown" aria-expanded="false"> |
caitmich
reviewed
Dec 11, 2024
caitmich
reviewed
Dec 11, 2024
| @@ -0,0 +1,19 @@ | |||
| <li class="nav-item dropdown"> | |||
| <a href="javascript:void(0)" class="nav-link dropdown-toggle" data-bs-toggle="dropdown" id="toolsDropdown"> | |||
There was a problem hiding this comment.
Suggested change
| <a href="javascript:void(0)" class="nav-link dropdown-toggle" data-bs-toggle="dropdown" id="toolsDropdown"> | |
| <a href="javascript:void(0)" class="nav-link dropdown-toggle" data-bs-toggle="dropdown"> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replacing the
Tyliumlayout with the initial implementation of theHeralayout. This brings many new improvements such as the navigation and sidebar redesigns. The layout is structured in a more modern way under the hood, preventing us from having to use workarounds or patches for certain functionality/interactions as we had to withTylium.This will serve as the foundation for further layout improvements that will be implemented incrementally.
Check List