Export all if all issues are in 'Draft' state #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aapomm
reviewed
Oct 8, 2024
app/controllers/export_controller.rb
Outdated
Comment on lines
13
to
14
| issue_states = current_project.issues.pluck(:state).uniq | ||
| (issue_states & NON_DRAFT_STATES).any? || non_draft_records_pro |
There was a problem hiding this comment.
Can we just check with:
Issue.published.or(Issue.ready_for_review).any?
this way, we don't have to fetch all issue states and iterate through each
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Users have said that they'd like the option to deactivate QA functionality altogether, because some teams don't use it and it has added extra clicks on export.
We need a way to keep the current flow for current teams who use QA, but improve the experience for teams that don't
Proposed solution
Detect in Export#index if all issues & content blocks in the project are in 'Draft' state. If they are, we can assume QA is NOT in use. If there are any 'ready for review' or 'published' records, then it's fair to assume QA IS in use.
If QA is not in use, auto-select "export all" and auto-update the button text to make it clear that all findings are being exported, saving users the extra click.
Check List