Update evidence screenshot links after node merge #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aapomm
reviewed
Oct 9, 2024
Comment on lines
+105
to
+106
| target_node.evidence_ids.each do |evidence_id| | ||
| evidence = Evidence.find(evidence_id) |
There was a problem hiding this comment.
What about
Suggested change
| target_node.evidence_ids.each do |evidence_id| | |
| evidence = Evidence.find(evidence_id) | |
| target_node.evidence.each do |evidence| |
aapomm
reviewed
Oct 9, 2024
| @@ -90,15 +92,33 @@ def update_properties | |||
| end | |||
|
|
|||
| def copy_attachments | |||
There was a problem hiding this comment.
This class is including the AttachmentsCopier that defines a copy_attachments method but this also defines a method with the same name. Should we differentiate the 2 and use a different name?
aapomm
reviewed
Oct 9, 2024
| end | ||
| end | ||
| end | ||
|
|
||
| def updated_record_content(record_content, full_screenshot_path, new_attachment) |
There was a problem hiding this comment.
updated_record_content doesn't quite describe what this method does. What about update_attachment_link or update_attachment_reference, or something else?
aapomm
reviewed
Oct 9, 2024
| def update_attachment_references | ||
| target_node.evidence_ids.each do |evidence_id| | ||
| evidence = Evidence.find(evidence_id) | ||
| evidence.content.scan(Attachment::SCREENSHOT_REGEX).each do |screenshot_path| |
There was a problem hiding this comment.
This is very similar to the AttachmentsCopier#copy_attachments method. Is there something we can reuse from there?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After merging nodes, screenshots in the Evidence content are left pointing to the old node. The attachments are copied over but the links are not updated. This means users face validation errors and have to manually update all screenshot references after merging nodes.
Check List