Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement importmaps #1188

Merged
merged 12 commits into from
Nov 2, 2023
Merged

Implement importmaps #1188

merged 12 commits into from
Nov 2, 2023

Conversation

aapomm
Copy link
Contributor

@aapomm aapomm commented Sep 26, 2023 •
edited by caitmich
Loading

Summary

  • Add importmap-rails gem
  • Run importmap install command
  • Update assets handling with the new manifest.js

Ensure that everything still works as expected

I assign all rights, including copyright, to any future Dradis
work by myself to Security Roots.

Check List

  • Added a CHANGELOG entry

@aapomm aapomm changed the base branch from rails-7-upgrade to rails-7-fix-specs September 29, 2023 09:44
caitmich
caitmich reviewed Oct 2, 2023
View reviewed changes
config/importmap.rb Outdated Show resolved Hide resolved
@caitmich caitmich changed the base branch from rails-7-fix-specs to rails-7-upgrade October 10, 2023 18:26
@caitmich caitmich merged commit 73933f7 into rails-7-upgrade Nov 2, 2023
3 checks passed
@caitmich caitmich deleted the importmaps branch November 2, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caitmich caitmich caitmich left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aapomm @caitmich