Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: isolate populate_obj in a separate method so that it can be easily overriden #2260

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

eqperes
Copy link

@eqperes eqperes commented Jul 16, 2024

Description

Similar to update_model on Flask-Admin, isolating the call to form.update_obj to a separate method allows the step to be easily overridden. Currently, the methods exposed can access either the form (process_form, for example) or the item (pre_add, pre_update, for example), but not both. Depending on the behavior to be implemented, access to both can be really useful.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Is CRUD MVC related.
  • Is Auth, RBAC security related.
  • Changes the security db schema.
  • Introduces new feature
  • Removes existing feature

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.65%. Comparing base (c65e067) to head (e8140f7).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2260      +/-   ##
==========================================
+ Coverage   73.81%   74.65%   +0.84%     
==========================================
  Files          72       72              
  Lines        8754     9041     +287     
==========================================
+ Hits         6462     6750     +288     
+ Misses       2292     2291       -1     
Flag Coverage Δ
python 74.65% <100.00%> (+0.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eqperes eqperes force-pushed the populate-item-separate-method branch from 04d62a5 to 83c8aff Compare August 22, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant