feat: Updating Hashing Method to PBKDF2 with SHA-256 #2234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark McCormick <[email protected]>
mamccorm
changed the title
mamccorm
changed the title
Signed-off-by: Mark McCormick <[email protected]>
|
Not sure why the python lint check in CI is still failing? I pushed up all fixes: % black setup.py flask_appbuilder
All done! ✨ 🍰 ✨
84 files left unchanged. |
mamccorm
changed the title
Signed-off-by: Mark McCormick <[email protected]>
dpgaspar
reviewed
May 13, 2024
There was a problem hiding this comment.
Thank you for the PR.
I think that the password hashing algorithm should be configurable, can you create a new config key named FAB_PASSWORD_HASH_METHOD
Seems that werkzeug has change the default hash method from pbkdf2 to scrypt: https://werkzeug.palletsprojects.com/en/3.0.x/utils/#module-werkzeug.security
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the password hashing mechanism from the current method to PBKDF2 with SHA-256. The change affects how passwords are processed within the Flask-AppBuilder security module.
By default, werkzeug uses
scrypt, which is not approved by FIPS, meaning anyone who wants to use this package inside an application which requires FIPS compliance will not be able to.ADDITIONAL INFORMATION