-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for UNIX domain sockets #120
Conversation
I think this is ready to be squash and merged. I can rebase the branch and force push myself if that's easier. The only existing interface I modified was The other notable change is that if you're using The PR workflow is still awaiting approval, but in the meantime the forked workflow results can be compared to the origin/HEAD workflow baseline. I still haven't gotten act running properly which is why there were so many commits towards the end. |
I have fixed ci on master branch. Would you please merge (or rebase) master first to see if unittest can pass? |
need a version bump, like this: #116 |
The server string implementation got more complicated than I expected and there's still dead code in there. It should get optimized out by the compiler. I don't think it'll present notable maintenance overhead, but would also understand a refactor request. |
After looking more closely at the default branch I realized there was a reason it was parsed the way it was. The PR implementation is still more complicated than the initial binding language solution but seemed worth it for the guaranteed language consistency. There is no longer dead code. |
One more bump on workflow approval please @lexdene (I assume? Can't tell who approved it). Looks like this was the issue. Works on my fork this time, should have caught the last one. |
interface for
memcached -s