Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use library-packs also when RestoreAdditionalProjectSources is explicitly set. #44863

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tmds
Copy link
Member

@tmds tmds commented Nov 14, 2024

library-packs are SDK features that implemented using bundled NuGet package files.

When a user sets RestoreAdditionalProjectSources, these features must remain available.

To disable library-packs features, a user may set DisableImplicitLibraryPacksFolder.

Fixes #44547.

@dsplaisted @nkolev92 @baronfel ptal.

…itly set.

library-packs are SDK features that implemented using bundled NuGet package files.

When a user sets RestoreAdditionalProjectSources, these features must remain available.

To disable library-packs features, a user may set DisableImplicitLibraryPacksFolder.
Copy link
Member

@dsplaisted dsplaisted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It would be good to have a basic test validating this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDK doesn't find/use bundled library-packs when additional NuGet sources are specified.
2 participants