Change some uses of EA_PTRSIZE to TARGET_POINTER_SIZE #49964
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
jkotas
approved these changes
Mar 21, 2021
|
cc @dotnet/jit-contrib The point of this change is to avoid use of |
| @@ -19775,7 +19775,7 @@ void Compiler::impInlineInitVars(InlineInfo* pInlineInfo) | |||
| return; | |||
| } | |||
| } | |||
| else if (genTypeSize(sigType) < EA_PTRSIZE) | |||
| else if (genTypeSize(sigType) < TARGET_POINTER_SIZE) | |||
|
Superseded by #50066 |
|
@BruceForstall @jkotas Thanks for picking this up. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes some occurrences of
EA_PTRSIZEtoTARGET_POINTER_SIZEfor the clrjit. This arises from the experimental work in dotnet/runtimelab#647 where the LLVM target does not haveEA_PTRSIZEdefined - its ininstr.hwhich is not included as the clrjit for LLVM does not proceed past the Rationalized LIR phase.