Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Zero Length check #23783

Closed
wants to merge 2 commits into from

Conversation

MikeAlhayek
Copy link

Fixes #23782

@MikeAlhayek MikeAlhayek requested a review from a team as a code owner July 23, 2024 20:45
@MikeAlhayek MikeAlhayek requested review from Eilon and jsuarezruiz July 23, 2024 20:45
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jul 23, 2024
Copy link
Contributor

Hey there @MikeAlhayek! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@mattleibow
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

mattleibow
mattleibow previously approved these changes Jul 23, 2024
@mgravell
Copy link
Member

@MikeAlhayek I notice you have raised a large number of similar PRs over multiple repos; these PRs appear to be based on the incorrect assumption that every use of ?.Length == 0 (or similar) is automatically incorrect. As I have tried to express at length over in SE.Redis / PR, this syntax is neither right nor wrong, but changing the intent to something else is almost certainly wrong, unless there is a specific example scenario described. I'm going to strongly suggest you close all of those PRs, and only redo them if you are very sure, based on a fully considered example, that the ?.Length usage is actually incorrect.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community ✨ Community Contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid Zero Length check expression
4 participants