Set a GroupName when creating new WinUI RadioButtons #13611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issue #11418
|
Will the random GroupNames cause problems later on with the implied grouping by container? |
ghost
added
the
legacy-area-controls
|
It doesn't seem to cause any problems from what I can tell. |
|
@jstedfast do you think you can add a device test? |
|
What would be the appropriate DeviceTests project to add tests for this to? Core.DeviceTests? Controls.DeviceTests? |
|
I would say Core.DeviceTests |
jstedfast
force-pushed
the
dev/jestedfa/issue11418
branch
from
ec56a0b to
6dd1f65
Compare
samhouts
reviewed
Mar 2, 2023
…le of the seconf group
Eilon
removed
the
legacy-area-controls
samhouts
added
the
fixed-in-8.0.0-preview.3.8149
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This change sets a unique GroupName on every WinUI RadioButton created so that different groups of MAUI RadioButtons are not assumed by WinUI to share the same group and thus prevent IsChecked values from being set properly.
Issues Fixed
Fixes #11418