Move extension methods in same assembly to be instance methods #5621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each of the middleware components for IChatClient / IEmbeddingGenerator currently has an additional class, each of which contains a single extension method for the corresponding builder. But they type being extended is in the same assembly; these may as well just be instance methods and avoid all the extra types (implementations in external assemblies would still use extensions, of course). Bonus, the code gets a bit cleaner as we don't have the extra arguments, arg validation, generic parameters, etc.
eiriktsarpalis
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each of the middleware components for IChatClient / IEmbeddingGenerator currently has an additional class, each of which contains a single extension method for the corresponding builder. But they type being extended is in the same assembly; these may as well just be instance methods and avoid all the extra types (implementations in external assemblies would still use extensions, of course). Bonus, the code gets a bit cleaner as we don't have the extra arguments, arg validation, generic parameters, etc.
Microsoft Reviewers: Open in CodeFlow