perf: improve allocations in OwinEnvironment
#58917
+635
−114
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,107 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using BenchmarkDotNet.Attributes; | ||
| using Microsoft.AspNetCore.Builder; | ||
| using Microsoft.AspNetCore.Http; | ||
| using Microsoft.Extensions.DependencyInjection; | ||
|
|
||
| namespace Microsoft.AspNetCore.Owin.Microbenchmarks.Benchmarks; | ||
|
|
||
| [MemoryDiagnoser] | ||
| public class OwinEnvironmentBenchmark | ||
| { | ||
| const int RequestCount = 10000; | ||
|
|
||
| RequestDelegate _noOperationRequestDelegate; | ||
| RequestDelegate _accessPortsRequestDelegate; | ||
| RequestDelegate _accessHeadersRequestDelegate; | ||
|
|
||
| HttpContext _defaultHttpContext; | ||
| HttpContext _httpContextWithHeaders; | ||
|
|
||
| [GlobalSetup] | ||
| public void GlobalSetup() | ||
| { | ||
| _noOperationRequestDelegate = BuildRequestDelegate(); | ||
| _accessPortsRequestDelegate = BuildRequestDelegate(beforeOwinInvokeAction: env => | ||
| { | ||
| _ = env.TryGetValue("server.LocalPort", out var localPort); | ||
| _ = env.TryGetValue("server.RemotePort", out var remotePort); | ||
| }); | ||
| _accessHeadersRequestDelegate = BuildRequestDelegate( | ||
| beforeOwinInvokeAction: env => | ||
| { | ||
| _ = env.TryGetValue("owin.RequestHeaders", out var requestHeaders); | ||
| }, | ||
| afterOwinInvokeAction: env => | ||
| { | ||
| _ = env.TryGetValue("owin.ResponseHeaders", out var responseHeaders); | ||
| } | ||
| ); | ||
|
|
||
| _defaultHttpContext = new DefaultHttpContext(); | ||
|
|
||
| _httpContextWithHeaders = new DefaultHttpContext(); | ||
| _httpContextWithHeaders.Request.Headers["CustomRequestHeader1"] = "CustomRequestValue"; | ||
| _httpContextWithHeaders.Request.Headers["CustomRequestHeader2"] = "CustomRequestValue"; | ||
| _httpContextWithHeaders.Response.Headers["CustomResponseHeader1"] = "CustomResponseValue"; | ||
| _httpContextWithHeaders.Response.Headers["CustomResponseHeader2"] = "CustomResponseValue"; | ||
| } | ||
|
|
||
| [Benchmark] | ||
| public async Task OwinRequest_NoOperation() | ||
| { | ||
| foreach (var i in Enumerable.Range(0, RequestCount)) | ||
| { | ||
| await _noOperationRequestDelegate(_defaultHttpContext); | ||
| } | ||
| } | ||
|
|
||
| [Benchmark] | ||
| public async Task OwinRequest_AccessPorts() | ||
| { | ||
| foreach (var i in Enumerable.Range(0, RequestCount)) | ||
| { | ||
| await _accessPortsRequestDelegate(_defaultHttpContext); | ||
| } | ||
| } | ||
|
|
||
| [Benchmark] | ||
| public async Task OwinRequest_AccessHeaders() | ||
| { | ||
| foreach (var i in Enumerable.Range(0, RequestCount)) | ||
| { | ||
| await _accessHeadersRequestDelegate(_httpContextWithHeaders); | ||
| } | ||
| } | ||
|
|
||
| private static RequestDelegate BuildRequestDelegate( | ||
| Action<IDictionary<string, object>> beforeOwinInvokeAction = null, | ||
| Action<IDictionary<string, object>> afterOwinInvokeAction = null) | ||
| { | ||
| var serviceProvider = new ServiceCollection().BuildServiceProvider(); | ||
| var builder = new ApplicationBuilder(serviceProvider); | ||
|
|
||
| return builder.UseOwin(addToPipeline => | ||
| { | ||
| addToPipeline(next => | ||
| { | ||
| return async env => | ||
| { | ||
| if (beforeOwinInvokeAction is not null) | ||
| { | ||
| beforeOwinInvokeAction(env); | ||
| } | ||
|
|
||
| await next(env); | ||
|
|
||
| if (afterOwinInvokeAction is not null) | ||
| { | ||
| afterOwinInvokeAction(env); | ||
| } | ||
| }; | ||
| }); | ||
| }).Build(); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <Reference Include="BenchmarkDotNet" /> | ||
| <Reference Include="Microsoft.AspNetCore.Http" /> | ||
| <Reference Include="Microsoft.AspNetCore.Owin" /> | ||
| <Reference Include="Microsoft.Extensions.DependencyInjection" /> | ||
|
|
||
| <Compile Include="$(SharedSourceRoot)BenchmarkRunner\*.cs" /> | ||
| </ItemGroup> | ||
|
|
||
| </Project> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using BenchmarkDotNet.Running; | ||
|
|
||
| BenchmarkSwitcher.FromAssembly(typeof(Program).Assembly).Run(); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: change to
NotSupportedException-NotImplementedExceptionsays "the library author is silly",NotSupportedExceptionsays "the caller is silly"trivial example in support of this (see
void IEnumerator.Reset()): https://sharplab.io/#v2:EYLgxg9gTgpgtADwGwBYA+ABADAAgwRhQG4BYAKHIwCYcAxCCHAb3LwGY982AeASwDsALgD4cAcRiD6EAM4AKAJTNO+HMFgBDANZEAvjgPldQA==