Update .NET SDK to 10.0.100-alpha.1.24553.6 #58776

github-actions · 2024-11-04T12:12:49Z

Updates the .NET SDK to version 10.0.100-alpha.1.24553.6, which also updates the .NET runtime from version 10.0.0-alpha.1.24507.22 to version 10.0.0-alpha.1.24552.2.

This pull request was auto-generated by GitHub Actions.

Update .NET SDK to version 10.0.100-alpha.1.24553.6. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

BrennanConroy

undo submodules?

sebastienros · 2024-11-04T18:11:54Z

undo submodules?

Sorry, this is my git client, I usually catch it in time. Will fix.

sebastienros · 2024-11-04T18:30:21Z

This is the result of https://github.com/dotnet/runtime/pull/109467/files

However XUnit should handle that now, so I will "try" (not even sure that's possible) to update the version we are using.
xunit/xunit#3021

sebastienros · 2024-11-05T01:57:16Z

The same template tests are failing on both windows and linux
https://dev.azure.com/dnceng-public/public/_build/results?buildId=860654&view=ms.vss-test-web.build-test-results-tab&runId=22386052&resultId=126271&paneView=debug

@javiercn anybody we can ask for help?

javiercn · 2024-11-05T12:28:54Z

@MackinnonBuck

eerhardt · 2024-11-05T23:14:34Z

...tection/test/Microsoft.AspNetCore.DataProtection.Tests/Cng/CbcAuthenticatedEncryptorTests.cs

@@ -29,7 +29,7 @@ public void Encrypt_Decrypt_RoundTrips()
        byte[] decipheredtext = encryptor.Decrypt(new ArraySegment<byte>(ciphertext), aad);

        // Assert
-        Assert.Equal(plaintext, decipheredtext);
+        Assert.Equal(plaintext.AsSpan(), decipheredtext.AsSpan());


@sebastienros - why is this change necessary now? Both expected and actual are byte[]. Why do they need to be cast to span?

eerhardt · 2024-11-06T23:56:10Z

@dotnet/source-build - the pre-built leg is failing:

.packages/microsoft.dotnet.arcade.sdk/10.0.0-beta.24551.1/tools/SourceBuild/AfterSourceBuild.proj(81,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/sb/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.NETCore.App.Ref.9.0.0-rc.2.24473.5

Any guidance on how to address this?

mthalman · 2024-11-07T13:44:51Z

@dotnet/source-build - the pre-built leg is failing:

.packages/microsoft.dotnet.arcade.sdk/10.0.0-beta.24551.1/tools/SourceBuild/AfterSourceBuild.proj(81,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/sb/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.NETCore.App.Ref.9.0.0-rc.2.24473.5

Any guidance on how to address this?

I'm pretty sure this requires that we have a .NET 9.0 targeting pack defined in SBRP. But we're going to want to wait until after this 10.0 SDK gets updated to reference the 9.0 GA version.

MichaelSimons · 2024-11-07T14:52:06Z

This can be marked as an allowed prebuilt IMO for the time being until we get the 9.0 GA targeting packs in SBRP.

MackinnonBuck · 2024-11-07T19:30:02Z

Looks like the project template test failures are caused by static web asset failures. I was able to repro this locally by running the project template tests:

Microsoft.NET.Sdk.StaticWebAssets.Compression.targets(242,5): warning : Endpoints not found for related asset: C:\aspnetcore\.packages\Other\microsoft.aspnetcore.identity.ui\10.0.0-dev\staticwebassets\V5\css\site.css [C:\aspnetcore\src\ProjectTemplates\test\Templates.Tests\bin\Release\net10.0\TestTemplates\AspNet.kd5bo3mwu5zn\AspNet.kd5bo3mwu5zn.csproj]
Microsoft.NET.Sdk.StaticWebAssets.Compression.targets(242,5): error MSB4018: The "ApplyCompressionNegotiation" task failed unexpectedly. [C:\aspnetcore\src\ProjectTemplates\test\Templates.Tests\bin\Release\net10.0\TestTemplates\AspNet.kd5bo3mwu5zn\AspNet.kd5bo3mwu5zn.csproj]
Microsoft.NET.Sdk.StaticWebAssets.Compression.targets(242,5): error MSB4018: System.InvalidOperationException: Endpoints not found for related asset: C:\aspnetcore\.packages\Other\microsoft.aspnetcore.identity.ui\10.0.0-dev\staticwebassets\V5\css\site.css [C:\aspnetcore\src\ProjectTemplates\test\Templates.Tests\bin\Release\net10.0\TestTemplates\AspNet.kd5bo3mwu5zn\AspNet.kd5bo3mwu5zn.csproj]
Microsoft.NET.Sdk.StaticWebAssets.Compression.targets(242,5): error MSB4018:    at Microsoft.AspNetCore.StaticWebAssets.Tasks.ApplyCompressionNegotiation.Execute() [C:\aspnetcore\src\ProjectTemplates\test\Templates.Tests\bin\Release\net10.0\TestTemplates\AspNet.kd5bo3mwu5zn\AspNet.kd5bo3mwu5zn.csproj]
Microsoft.NET.Sdk.StaticWebAssets.Compression.targets(242,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Execute() [C:\aspnetcore\src\ProjectTemplates\test\Templates.Tests\bin\Release\net10.0\TestTemplates\AspNet.kd5bo3mwu5zn\AspNet.kd5bo3mwu5zn.csproj]
Microsoft.NET.Sdk.StaticWebAssets.Compression.targets(242,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(TaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) [C:\aspnetcore\src\ProjectTemplates\test\Templates.Tests\bin\Release\net10.0\TestTemplates\AspNet.kd5bo3mwu5zn\AspNet.kd5bo3mwu5zn.csproj]

cc @javiercn

javiercn · 2024-11-07T19:39:12Z

@MackinnonBuck thanks.

I'll take a look at it tomorrow first thing in the morning.

javiercn · 2024-11-08T09:48:24Z

I'm getting the following error. Any idea how to get past it?

LINK : fatal error C1900: Il mismatch between 'P1' version '20231109' and 'P2' version '20230904' [D:\work\aspnetcore\src\Servers\IIS\AspNetCoreModuleV2\AspNetCore\AspNetCore.vcxproj]
LINK : fatal error LNK1257: code generation failed [D:\work\aspnetcore\src\Servers\IIS\AspNetCoreModuleV2\AspNetCore\AspNetCore.vcxproj]
LINK : fatal error C1900: Il mismatch between 'P1' version '20231109' and 'P2' version '20230904' [D:\work\aspnetcore\src\Servers\IIS\AspNetCoreModuleV2\AspNetCore\AspNetCore.vcxproj]
LINK : fatal error LNK1257: code generation failed [D:\work\aspnetcore\src\Servers\IIS\AspNetCoreModuleV2\AspNetCore\AspNetCore.vcxproj]
LINK : fatal error C1007: unrecognized flag '-ArmArchitectureLevel8' in 'p2' [D:\work\aspnetcore\src\Servers\IIS\AspNetCoreModuleV2\AspNetCore\AspNetCore.vcxproj]
LINK : fatal error LNK1257: code generation failed [D:\work\aspnetcore\src\Servers\IIS\AspNetCoreModuleV2\AspNetCore\AspNetCore.vcxproj]
LINK : fatal error C1900: Il mismatch between 'P1' version '20231109' and 'P2' version '20230904' [D:\work\aspnetcore\src\Servers\IIS\AspNetCoreModuleV2\InProcessRequestHandler\InProcessRequestHand
ler.vcxproj]
LINK : fatal error LNK1257: code generation failed [D:\work\aspnetcore\src\Servers\IIS\AspNetCoreModuleV2\InProcessRequestHandler\InProcessRequestHandler.vcxproj]
LINK : fatal error C1900: Il mismatch between 'P1' version '20231109' and 'P2' version '20230904' [D:\work\aspnetcore\src\Servers\IIS\AspNetCoreModuleV2\InProcessRequestHandler\InProcessRequestHand
ler.vcxproj]
LINK : fatal error LNK1257: code generation failed [D:\work\aspnetcore\src\Servers\IIS\AspNetCoreModuleV2\InProcessRequestHandler\InProcessRequestHandler.vcxproj]
LINK : fatal error C1007: unrecognized flag '-ArmArchitectureLevel8' in 'p2' [D:\work\aspnetcore\src\Servers\IIS\AspNetCoreModuleV2\InProcessRequestHandler\InProcessRequestHandler.vcxproj]
LINK : fatal error LNK1257: code generation failed [D:\work\aspnetcore\src\Servers\IIS\AspNetCoreModuleV2\InProcessRequestHandler\InProcessRequestHandler.vcxproj]

javiercn · 2024-11-08T14:40:59Z

@MackinnonBuck can you get me the binlog?

eerhardt · 2024-11-08T18:14:14Z

src/Identity/UI/src/Microsoft.AspNetCore.Identity.UI.csproj

@@ -122,11 +122,13 @@
    <GenerateStaticWebAssetEndpointsPropsFile
      StaticWebAssets="@(V4Assets)"
      StaticWebAssetEndpoints="@(V4AssetEndpoints)"
+      PackagePathPrefix="staticwebassets/V4"


Do we know what changed to break this? Is this a sign of some underlying bug?

I don't know yet, but I plan to look at it on Monday, at a quick glance, the endpoints in the package are incorrect too (we will have to service that).

It doesn't currently fail I think because we have a process to "upgrade" older packages and define endpoints and the endpoints end up being generated as part of the user build.

Not sure what the difference is between the build in the repo and the end user build that causes it to fail here. In the end, it's a bug in the package.

Filed an issue to track

github-actions · 2024-11-11T12:12:15Z

Superseded by #58862.

sebastienros · 2024-11-11T18:15:48Z

I think we should restore this branch and get it in a mergeable state, otherwise we'll need to apply the same changes (and there are lots of them) in the new PR. We can keep the other PR and it will hopefully just work when this one is in. @eerhardt @MackinnonBuck

eerhardt · 2024-11-11T19:04:37Z

I think we should restore this branch and get it in a mergeable state, otherwise we'll need to apply the same changes (and there are lots of them) in the new PR. We can keep the other PR and it will hopefully just work when this one is in. @eerhardt @MackinnonBuck

Agreed. I suggest closing the new PR and re-open this PR.

javiercn · 2024-11-11T23:18:41Z

We can't reopen the original one because the branch got deleted

sebastienros · 2024-11-11T23:25:42Z

The branch was recreated (or force pushed) I believe by Eric. We can see it: https://github.com/dotnet/aspnetcore/branches/all?query=update-dotnet-sdk-10.0.100-alpha.1.24553.6&lastTab=overview

We may just need a new PR

github-actions bot requested review from wtgodbe and a team as code owners November 4, 2024 12:12

github-actions bot mentioned this pull request Nov 4, 2024

Update .NET SDK to 10.0.100-alpha.1.24527.7 #58671

Closed

dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Nov 4, 2024

dotnet-policy-service bot added the Type: Dependency Update 🔼 label Nov 4, 2024

sebastienros requested review from halter73, BrennanConroy, JamesNK, mgravell, a team and captainsafia as code owners November 4, 2024 17:48

BrennanConroy reviewed Nov 4, 2024

View reviewed changes

Fix build errors

f30edff

sebastienros force-pushed the update-dotnet-sdk-10.0.100-alpha.1.24553.6 branch from b5d1656 to f30edff Compare November 4, 2024 18:13

sebastienros added 7 commits November 4, 2024 11:07

Revert changes

3007125

Update XUnit package

1f9529c

Fix build errors

b647ece

Fix arrays

9962cc5

Fix Http tests

d66e6c5

Fix more errors

e52323e

Fix MVC

540cf1a

jkoritzinsky mentioned this pull request Nov 5, 2024

Convert ref and runtime packs to use the SharedFramework SDK and Arcade's installer tooling #58612

Open

eerhardt reviewed Nov 5, 2024

View reviewed changes

Flip around where AsSpan is called with string comparisons in tests.

0f9d339

eerhardt force-pushed the update-dotnet-sdk-10.0.100-alpha.1.24553.6 branch from 7a8ae19 to 0f9d339 Compare November 6, 2024 00:56

Include package path prefix on Identity UI packages

0af0f15

eerhardt reviewed Nov 8, 2024

View reviewed changes

javiercn mentioned this pull request Nov 8, 2024

[Identity][UI] Fix asset path for endpoint definitions #58841

Open

radical mentioned this pull request Nov 8, 2024

[main] Update dependencies from dotnet/efcore, dotnet/runtime #58772

Open

github-actions bot closed this Nov 11, 2024

github-actions bot deleted the update-dotnet-sdk-10.0.100-alpha.1.24553.6 branch November 11, 2024 12:12

dotnet-policy-service bot added this to the 10.0-preview1 milestone Nov 11, 2024

sebastienros mentioned this pull request Nov 11, 2024

Update .NET SDK to 10.0.100-alpha.1.24560.6 #58862

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update .NET SDK to 10.0.100-alpha.1.24553.6 #58776

Update .NET SDK to 10.0.100-alpha.1.24553.6 #58776

github-actions bot commented Nov 4, 2024

BrennanConroy left a comment

sebastienros commented Nov 4, 2024

sebastienros commented Nov 4, 2024

sebastienros commented Nov 5, 2024

javiercn commented Nov 5, 2024

eerhardt Nov 5, 2024

eerhardt commented Nov 6, 2024

mthalman commented Nov 7, 2024

MichaelSimons commented Nov 7, 2024

MackinnonBuck commented Nov 7, 2024

javiercn commented Nov 7, 2024

javiercn commented Nov 8, 2024 •

edited

Loading

javiercn commented Nov 8, 2024

eerhardt Nov 8, 2024

javiercn Nov 8, 2024

javiercn Nov 8, 2024

github-actions bot commented Nov 11, 2024

sebastienros commented Nov 11, 2024

eerhardt commented Nov 11, 2024

javiercn commented Nov 11, 2024

sebastienros commented Nov 11, 2024

Update .NET SDK to 10.0.100-alpha.1.24553.6 #58776

Update .NET SDK to 10.0.100-alpha.1.24553.6 #58776

Conversation

github-actions bot commented Nov 4, 2024

BrennanConroy left a comment

Choose a reason for hiding this comment

sebastienros commented Nov 4, 2024

sebastienros commented Nov 4, 2024

sebastienros commented Nov 5, 2024

javiercn commented Nov 5, 2024

eerhardt Nov 5, 2024

Choose a reason for hiding this comment

eerhardt commented Nov 6, 2024

mthalman commented Nov 7, 2024

MichaelSimons commented Nov 7, 2024

MackinnonBuck commented Nov 7, 2024

javiercn commented Nov 7, 2024

javiercn commented Nov 8, 2024 • edited Loading

javiercn commented Nov 8, 2024

eerhardt Nov 8, 2024

Choose a reason for hiding this comment

javiercn Nov 8, 2024

Choose a reason for hiding this comment

javiercn Nov 8, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 11, 2024

sebastienros commented Nov 11, 2024

eerhardt commented Nov 11, 2024

javiercn commented Nov 11, 2024

sebastienros commented Nov 11, 2024

javiercn commented Nov 8, 2024 •

edited

Loading