Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Aspire.Hosting.Valkey.Tests project #4930

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented Jul 16, 2024

Contributes to #3185
Contributes to #4294

Microsoft Reviewers: Open in CodeFlow

@eerhardt eerhardt requested a review from sebastienros July 16, 2024 20:27
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-integrations Issues pertaining to Aspire Integrations packages label Jul 16, 2024
Copy link
Member

@radical radical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the feedback, LGTM 👍

@eerhardt eerhardt enabled auto-merge (squash) July 16, 2024 21:38
@radical radical closed this Jul 16, 2024
auto-merge was automatically disabled July 16, 2024 22:02

Pull request was closed

@radical radical reopened this Jul 16, 2024
@radical
Copy link
Member

radical commented Jul 16, 2024

Closed/re-opened to get changes from main which have the fix for Kakfa test failures.

@radical radical enabled auto-merge (squash) July 16, 2024 22:03
@radical radical merged commit 6de43ed into dotnet:main Jul 16, 2024
10 checks passed
@eerhardt eerhardt deleted the ExtractValkeyTests branch July 17, 2024 03:18
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants