-
Notifications
You must be signed in to change notification settings - Fork 521
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Extract Aspire.Hosting.Milvus.Tests project (#4875)
* Extract Aspire.Hosting.Milvus.Tests project Contributes to #3185 Contributes to #4294 * Update tests/Aspire.Hosting.Milvus.Tests/MilvusFunctionalTests.cs Co-authored-by: Ankit Jain <[email protected]> * Update tests/Aspire.Hosting.Milvus.Tests/Aspire.Hosting.Milvus.Tests.csproj Co-authored-by: Ankit Jain <[email protected]> * Apply feedback * remove launch profile * Remove milvus from the EndToEnd tests --------- Co-authored-by: Eric Erhardt <[email protected]> Co-authored-by: Ankit Jain <[email protected]> Co-authored-by: Sébastien Ros <[email protected]>
- Loading branch information
4 people
authored
Jul 22, 2024
1 parent
0600f06
commit 2576de3
Showing
14 changed files
with
289 additions
and
98 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
tests/Aspire.Hosting.Milvus.Tests/Aspire.Hosting.Milvus.Tests.csproj
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>$(NetCurrent)</TargetFramework> | ||
| <NoWarn>$(NoWarn);CS8002</NoWarn> <!-- Milvus.Client packages are not signed --> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="..\..\src\Aspire.Hosting.AppHost\Aspire.Hosting.AppHost.csproj" /> | ||
| <ProjectReference Include="..\..\src\Aspire.Hosting.Milvus\Aspire.Hosting.Milvus.csproj" /> | ||
| <ProjectReference Include="..\..\src\Components\Aspire.Milvus.Client\Aspire.Milvus.Client.csproj" /> | ||
| <ProjectReference Include="..\Aspire.Hosting.Tests\Aspire.Hosting.Tests.csproj" /> | ||
|
|
||
| <PackageReference Include="Microsoft.Extensions.Http.Resilience" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <Compile Include="$(RepoRoot)src\Aspire.Hosting.Milvus\MilvusContainerImageTags.cs" /> | ||
| <Compile Include="$(SharedDir)VolumeNameGenerator.cs" Link="Utils\VolumeNameGenerator.cs" /> | ||
| </ItemGroup> | ||
| </Project> |
244 changes: 244 additions & 0 deletions
244
tests/Aspire.Hosting.Milvus.Tests/MilvusFunctionalTests.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,244 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using Aspire.Components.Common.Tests; | ||
| using Aspire.Hosting.Utils; | ||
| using Grpc.Core; | ||
| using Microsoft.Extensions.Configuration; | ||
| using Microsoft.Extensions.DependencyInjection; | ||
| using Microsoft.Extensions.Hosting; | ||
| using Microsoft.Extensions.Logging; | ||
| using Milvus.Client; | ||
| using Polly; | ||
| using Xunit; | ||
| using Xunit.Abstractions; | ||
|
|
||
| namespace Aspire.Hosting.Milvus.Tests; | ||
|
|
||
| public class MilvusFunctionalTests(ITestOutputHelper testOutputHelper) | ||
| { | ||
| // Right now can not set user and password for super user of Milvus at startup. default user and password is root:Milvus. | ||
| // https://github.com/milvus-io/milvus/issues/33058 | ||
| private const string MilvusToken = "root:Milvus"; | ||
| private const string CollectionName = "book"; | ||
|
|
||
| [Fact] | ||
| [RequiresDocker] | ||
| public async Task VerifyMilvusResource() | ||
| { | ||
| var cts = new CancellationTokenSource(TimeSpan.FromMinutes(5)); | ||
| var pipeline = new ResiliencePipelineBuilder() | ||
| .AddRetry(new() { MaxRetryAttempts = 10, Delay = TimeSpan.FromSeconds(3), ShouldHandle = new PredicateBuilder().Handle<RpcException>() }) | ||
| .Build(); | ||
|
|
||
| var builder = CreateDistributedApplicationBuilder(); | ||
|
|
||
| builder.Configuration["Parameters:apikey"] = MilvusToken; | ||
| var apiKey = builder.AddParameter("apikey"); | ||
| var milvus = builder.AddMilvus("milvus", apiKey: apiKey); | ||
| var db = milvus.AddDatabase("milvusdb", "db1"); | ||
|
|
||
| using var app = builder.Build(); | ||
|
|
||
| await app.StartAsync(); | ||
|
|
||
| var hb = Host.CreateApplicationBuilder(); | ||
|
|
||
| hb.Configuration.AddInMemoryCollection(new Dictionary<string, string?> | ||
| { | ||
| [$"ConnectionStrings:{db.Resource.Name}"] = await db.Resource.ConnectionStringExpression.GetValueAsync(default) | ||
| }); | ||
|
|
||
| hb.AddMilvusClient(db.Resource.Name); | ||
|
|
||
| using var host = hb.Build(); | ||
|
|
||
| await host.StartAsync(); | ||
|
|
||
| await pipeline.ExecuteAsync( | ||
| async token => | ||
| { | ||
| var milvusClient = host.Services.GetRequiredService<MilvusClient>(); | ||
|
|
||
| await milvusClient.CreateDatabaseAsync("db1", token); | ||
| await CreateTestDataAsync(milvusClient, token); | ||
|
|
||
| }, cts.Token); | ||
|
|
||
| } | ||
|
|
||
| private static async Task CreateTestDataAsync(MilvusClient milvusClient, CancellationToken token) | ||
| { | ||
| var collection = await milvusClient.CreateCollectionAsync( | ||
| CollectionName, | ||
| [ | ||
| FieldSchema.Create<long>("book_id", isPrimaryKey:true), | ||
| FieldSchema.Create<long>("word_count"), | ||
| FieldSchema.CreateVarchar("book_name", 256), | ||
| FieldSchema.CreateFloatVector("book_intro", 2) | ||
| ] | ||
| , cancellationToken: token); | ||
|
|
||
| var collections = await milvusClient.ListCollectionsAsync(cancellationToken: token); | ||
| Assert.Single(collections, c => c.Name == CollectionName); | ||
| } | ||
|
|
||
| [Theory] | ||
| [InlineData(false)] | ||
| [InlineData(true)] | ||
| [RequiresDocker] | ||
| public async Task WithDataShouldPersistStateBetweenUsages(bool useVolume) | ||
| { | ||
| var dbname = "milvusdbtest"; | ||
| var cts = new CancellationTokenSource(TimeSpan.FromMinutes(5)); | ||
| var pipeline = new ResiliencePipelineBuilder() | ||
| .AddRetry(new() { MaxRetryAttempts = 10, Delay = TimeSpan.FromSeconds(3), ShouldHandle = new PredicateBuilder().Handle<RpcException>() }) | ||
| .Build(); | ||
|
|
||
| string? volumeName = null; | ||
| string? bindMountPath = null; | ||
|
|
||
| try | ||
| { | ||
| var builder1 = CreateDistributedApplicationBuilder(); | ||
| builder1.Configuration["Parameters:apikey"] = MilvusToken; | ||
| var apiKey1 = builder1.AddParameter("apikey"); | ||
| var milvus1 = builder1.AddMilvus("milvus1", apiKey1); | ||
| var db1 = milvus1.AddDatabase("milvusdb1", dbname); | ||
|
|
||
| if (useVolume) | ||
| { | ||
| // Use a deterministic volume name to prevent them from exhausting the machines if deletion fails | ||
| volumeName = VolumeNameGenerator.CreateVolumeName(milvus1, nameof(WithDataShouldPersistStateBetweenUsages)); | ||
|
|
||
| // if the volume already exists (because of a crashing previous run), try to delete it | ||
| DockerUtils.AttemptDeleteDockerVolume(volumeName); | ||
| milvus1.WithDataVolume(volumeName); | ||
| } | ||
| else | ||
| { | ||
| bindMountPath = Path.Combine(Path.GetTempPath(), Path.GetRandomFileName()); | ||
| milvus1.WithDataBindMount(bindMountPath); | ||
| } | ||
|
|
||
| using (var app = builder1.Build()) | ||
| { | ||
| await app.StartAsync(); | ||
|
|
||
| try | ||
| { | ||
| var hb = Host.CreateApplicationBuilder(); | ||
|
|
||
| hb.Configuration.AddInMemoryCollection(new Dictionary<string, string?> | ||
| { | ||
| [$"ConnectionStrings:{db1.Resource.Name}"] = await db1.Resource.ConnectionStringExpression.GetValueAsync(default) | ||
| }); | ||
|
|
||
| hb.AddMilvusClient(db1.Resource.Name); | ||
|
|
||
| using (var host = hb.Build()) | ||
| { | ||
| await host.StartAsync(); | ||
|
|
||
| await pipeline.ExecuteAsync( | ||
| async token => | ||
| { | ||
| var milvusClient = host.Services.GetRequiredService<MilvusClient>(); | ||
|
|
||
| await milvusClient.CreateDatabaseAsync(dbname, token); | ||
| await CreateTestDataAsync(milvusClient, token); | ||
|
|
||
| }, cts.Token); | ||
|
|
||
| } | ||
| } | ||
| finally | ||
| { | ||
| // Stops the container, or the Volume would still be in use | ||
| await app.StopAsync(); | ||
| } | ||
| } | ||
|
|
||
| var builder2 = CreateDistributedApplicationBuilder(); | ||
| builder2.Configuration["Parameters:apikey"] = MilvusToken; | ||
| var apiKey2 = builder2.AddParameter("apikey"); | ||
| var milvus2 = builder2.AddMilvus("milvus2", apiKey2); | ||
| var db2 = milvus2.AddDatabase("milvusdb2", dbname); | ||
|
|
||
| if (useVolume) | ||
| { | ||
| milvus2.WithDataVolume(volumeName); | ||
| } | ||
| else | ||
| { | ||
| milvus2.WithDataBindMount(bindMountPath!); | ||
| } | ||
|
|
||
| using (var app = builder2.Build()) | ||
| { | ||
| await app.StartAsync(); | ||
|
|
||
| try | ||
| { | ||
| var hb = Host.CreateApplicationBuilder(); | ||
|
|
||
| hb.Configuration.AddInMemoryCollection(new Dictionary<string, string?> | ||
| { | ||
| [$"ConnectionStrings:{db2.Resource.Name}"] = await db2.Resource.ConnectionStringExpression.GetValueAsync(default) | ||
| }); | ||
|
|
||
| hb.AddMilvusClient(db2.Resource.Name); | ||
|
|
||
| using (var host = hb.Build()) | ||
| { | ||
| await host.StartAsync(); | ||
|
|
||
| await pipeline.ExecuteAsync( | ||
| async token => | ||
| { | ||
| var milvusClient = host.Services.GetRequiredService<MilvusClient>(); | ||
|
|
||
| var collections = await milvusClient.ListCollectionsAsync(cancellationToken: token); | ||
|
|
||
| Assert.Single(collections, c => c.Name == CollectionName); | ||
|
|
||
| }, cts.Token); | ||
| } | ||
| } | ||
| finally | ||
| { | ||
| // Stops the container, or the Volume would still be in use | ||
| await app.StopAsync(); | ||
| } | ||
|
|
||
| } | ||
|
|
||
| } | ||
| finally | ||
| { | ||
| if (volumeName is not null) | ||
| { | ||
| DockerUtils.AttemptDeleteDockerVolume(volumeName); | ||
| } | ||
|
|
||
| if (bindMountPath is not null) | ||
| { | ||
| try | ||
| { | ||
| Directory.Delete(bindMountPath, recursive: true); | ||
| } | ||
| catch | ||
| { | ||
| // Don't fail test if we can't clean the temporary folder | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private TestDistributedApplicationBuilder CreateDistributedApplicationBuilder() | ||
| { | ||
| var builder = TestDistributedApplicationBuilder.CreateWithTestContainerRegistry(); | ||
| builder.Services.AddXunitLogging(testOutputHelper); | ||
| return builder; | ||
| } | ||
| } |
Oops, something went wrong.