Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial example #3452

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Tutorial example #3452

wants to merge 2 commits into from

Conversation

gilgardosh
Copy link
Collaborator

@gilgardosh gilgardosh commented Oct 31, 2024

New example to match the current Yoga tutorial

@gilgardosh gilgardosh self-assigned this Oct 31, 2024
Copy link

changeset-bot bot commented Oct 31, 2024

⚠️ No Changeset found

Latest commit: a60099b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 31, 2024

Apollo Federation Subgraph Compatibility Results

Federation 1 Support Federation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🟢
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

Copy link
Contributor

github-actions bot commented Oct 31, 2024

💻 Website Preview

The latest changes are available as preview in: https://fa4b2b77.graphql-yoga.pages.dev

Copy link
Contributor

github-actions bot commented Oct 31, 2024

✅ Benchmark Results

     ✓ no_errors{mode:graphql}
     ✓ expected_result{mode:graphql}
     ✓ no_errors{mode:graphql-jit}
     ✓ expected_result{mode:graphql-jit}
     ✓ no_errors{mode:graphql-response-cache}
     ✓ expected_result{mode:graphql-response-cache}
     ✓ no_errors{mode:graphql-no-parse-validate-cache}
     ✓ expected_result{mode:graphql-no-parse-validate-cache}
     ✓ no_errors{mode:uws}
     ✓ expected_result{mode:uws}

     checks.......................................: 100.00% ✓ 523196      ✗ 0     
     data_received................................: 2.1 GB  14 MB/s
     data_sent....................................: 105 MB  701 kB/s
     http_req_blocked.............................: avg=1.47µs   min=922ns    med=1.31µs   max=417.62µs p(90)=1.96µs   p(95)=2.14µs  
     http_req_connecting..........................: avg=2ns      min=0s       med=0s       max=202.4µs  p(90)=0s       p(95)=0s      
     http_req_duration............................: avg=357.92µs min=216.84µs med=324.31µs max=15.36ms  p(90)=456.89µs p(95)=476.13µs
       { expected_response:true }.................: avg=357.92µs min=216.84µs med=324.31µs max=15.36ms  p(90)=456.89µs p(95)=476.13µs
     ✓ { mode:graphql-jit }.......................: avg=289.52µs min=216.84µs med=267.82µs max=15.36ms  p(90)=298.41µs p(95)=312.94µs
     ✓ { mode:graphql-no-parse-validate-cache }...: avg=483.24µs min=400.3µs  med=459.16µs max=9.19ms   p(90)=496.75µs p(95)=526.04µs
     ✓ { mode:graphql-response-cache }............: avg=339.59µs min=267.14µs med=321.6µs  max=9.1ms    p(90)=350.83µs p(95)=361.74µs
     ✓ { mode:graphql }...........................: avg=367.49µs min=276.86µs med=334.31µs max=13.52ms  p(90)=388.25µs p(95)=431.93µs
     ✓ { mode:uws }...............................: avg=343.78µs min=273.11µs med=324.46µs max=9.09ms   p(90)=356.54µs p(95)=372.4µs 
     http_req_failed..............................: 0.00%   ✓ 0           ✗ 261598
     http_req_receiving...........................: avg=33.05µs  min=16.68µs  med=33.2µs   max=5.72ms   p(90)=38.68µs  p(95)=40.76µs 
     http_req_sending.............................: avg=8.44µs   min=5.94µs   med=7.47µs   max=447.53µs p(90)=10.95µs  p(95)=11.74µs 
     http_req_tls_handshaking.....................: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting.............................: avg=316.41µs min=186.89µs med=283.49µs max=15.26ms  p(90)=414.9µs  p(95)=432.14µs
     http_reqs....................................: 261598  1743.963307/s
     iteration_duration...........................: avg=568.48µs min=384.99µs med=531.95µs max=15.87ms  p(90)=671.51µs p(95)=695.01µs
     iterations...................................: 261598  1743.963307/s
     vus..........................................: 1       min=1         max=1   
     vus_max......................................: 2       min=2         max=2   

@gilgardosh gilgardosh marked this pull request as draft November 5, 2024 11:53
@gilgardosh gilgardosh force-pushed the tutorial-example branch 4 times, most recently from b3b07c7 to f6e5c3e Compare November 5, 2024 13:01
@gilgardosh gilgardosh marked this pull request as ready for review November 5, 2024 14:32
Copy link
Collaborator

@n1ru4l n1ru4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be within examples/hackernews instead? Also we had integration tests for the other example. It might sense to also add them here.

@gilgardosh gilgardosh force-pushed the tutorial-example branch 2 times, most recently from ddbd3e9 to 4eb01ef Compare November 11, 2024 13:06
@gilgardosh gilgardosh force-pushed the tutorial-example branch 3 times, most recently from 9564025 to 07c98e5 Compare November 11, 2024 14:59
@gilgardosh
Copy link
Collaborator Author

@n1ru4l I ended up merging it into the hackernews example.
I intentionally split it into 2 commits:
The first one is without the final stage, second is the complete thing - as the codegen "magic" in the last tutorial step makes stuff less upfront and harder to navigate.
Maybe worth mark it as a bonus step and remove the last commit? what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants