Respect Accept headers in a more strict way #1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 454013c The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Related: graphql/graphql-over-http#167 |
✅ Benchmark Results |
|
|
ardatan
changed the title
|
The latest changes of this PR are not available as canary, since there are no linked |
ardatan
force-pushed
the
respect-accept-headers
branch
from
e3a09cb
to
454013c
Compare
n1ru4l
reviewed
Aug 1, 2022
Comment on lines
+1486
to
+1500
| describe('Respect Accept headers', () => { | ||
| const yoga = createYoga({ | ||
| schema, | ||
| }) | ||
| const server = createServer(yoga) | ||
| let port: number | ||
| let url: string | ||
| beforeAll((done) => { | ||
| port = Math.floor(Math.random() * 100) + 4000 | ||
| url = `http://localhost:${port}/graphql` | ||
| server.listen(port, done) | ||
| }) | ||
| afterAll(() => { | ||
| server.close() | ||
| }) |
There was a problem hiding this comment.
I think these tests do not necessarily require running a Node HTTP server, but we can change it later on.
There was a problem hiding this comment.
I think it is safer to test stream requests and responses via the really HTTP
n1ru4l
reviewed
Aug 1, 2022
Comment on lines
+1531
to
+1538
| it('should not allow to return if the result is an async iterable and accept is just json', async () => { | ||
| const response = await fetch(`${url}?query=subscription{counter}`, { | ||
| headers: { | ||
| Accept: 'application/json', | ||
| }, | ||
| }) | ||
| expect(response.status).toEqual(406) | ||
| }) |
There was a problem hiding this comment.
Hmmmmm, here it could actually be debatable whether it is okay for the client to only wait for the first event and then ditch the subscription 🤔
Closed
This was referenced Sep 21, 2022
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related ##1503 (comment)
Closes #1504
Currently Yoga processes only async iterable results according to the accept header, but instead we should respect the header even for regular results. So async iterable check should be done only for json responses.