Core tests #119
Merged
Core tests #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kilianp14
commented
Aug 10, 2023
kilianp14
commented
- Added tests for all core modules to achieve 100% branch coverage in vessim.core
- Some minor bug fixes
marvin-steinke
approved these changes
Aug 10, 2023
birnbaum
reviewed
Aug 23, 2023
birnbaum
approved these changes
Aug 23, 2023
Comment on lines
+36
to
+37
| def test_measure(self, power_meter): | ||
| assert power_meter.measure() == 20.0 |
There was a problem hiding this comment.
how does the power meter know which power mode to chose initially? the first in the dict?
There was a problem hiding this comment.
The initial power mode is "high performance" as specified in the docstring of the MockPowerMeter class
Comment on lines
+55
to
+58
| try: | ||
| computing_system.finalize() | ||
| except Exception as err: | ||
| pytest.fail(f"Unexpected Error: {err}") |
There was a problem hiding this comment.
what is being tested here?
There was a problem hiding this comment.
It is just a test to check if the finalize function throws an error. I just wrote this test to achieve full code coverage, but I agree that it is not very useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.