Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLUGINRANGERS-3038 | Prevent false prices + actual bugfix of normalization #350

Conversation

davidmolinacano
Copy link
Contributor

@davidmolinacano davidmolinacano commented Dec 4, 2024

Required by:

Actually fixes:

This PR prevents prices to be returned as false, so instead, they will be treated as 0, so '' will be returned instead (tested directly on the customer's WP and works):

image

Apart from this, I have noticed that the fix applied on https://github.com/doofinder/support/issues/3053 was not working as expected, since now the original SE was being retrieved as "no-hash". Now every SE have their hashids correctly assigned:

{
   "store_options":{
      "url":"http:\\/\\/david-wordpress.ngrok.doofinder.com",
      "api_pass":"************************",
      "api_user":"*****",
      "df_token":"************************"
   },
   "platform":"woocommerce",
   "search_engines":{
      "98ed13ef9bb6627cf9cb953437a7a8ce":{
         "lang":"en"
      },
      "331bef2efc54c931693b57cc0075f1dc":{
         "lang":"es"
      }
   }
}

Copy link
Member

@pedromcp90 pedromcp90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@davidmolinacano
Copy link
Contributor Author

Since tomorrow is a bank holiday day, I'm holding until Monday, since the issue has been solved directly on the client side and it's a strange case.

@davidmolinacano davidmolinacano merged commit 219cd8a into master Dec 9, 2024
4 checks passed
@davidmolinacano davidmolinacano deleted the davidmolinacano/pluginrangers/3038/prevent_prices_as_false_and_bugfix branch December 9, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants