-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cambios Multicurrency Prestashop #258
base: master
Are you sure you want to change the base?
Cambios Multicurrency Prestashop #258
Conversation
@@ -76,6 +76,7 @@ public static function setDefaultShopConfig($shopGroupId, $shopId) | |||
\Configuration::updateValue('DF_GS_DESCRIPTION_TYPE', DoofinderConstants::GS_SHORT_DESCRIPTION, false, $shopGroupId, $shopId); | |||
\Configuration::updateValue('DF_FEED_MAINCATEGORY_PATH', false, false, $shopGroupId, $shopId); | |||
\Configuration::updateValue('DF_GS_IMAGE_SIZE', key(DfTools::getAvailableImageSizes()), false, $shopGroupId, $shopId); | |||
\Configuration::updateValue('DF_MULTIPRICE_ENABLED', true, false, $shopGroupId, $shopId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ogomezba tengo una duda con esto, al meter este valor con shopGroupId y con shopId entiendo que esto es una entrada por cada tienda que haya (para el caso de multi-tienda) pero esto es realmente así? es que no me suena que el campo DF_REGION
por ejemplo cuando hago la consulta en base de datos esté duplicado, pero igual es que simplemente no he prestado atención. Pero quería confirmarlo contigo antes que darlo por hecho, solo por asegurar que vamos a tener uno de esto por cada shop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hola @sofia-doofinder ! Sí, como parte de las pruebas he estado revisando que al final tuviéramos esta configuración por store y así era. Respecto a lo de la DF_REGION
que comentas, para mi prestashop actual multistore tengo
por lo que en principio está todo en orden.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
genial! muchas gracias por la confirmación
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🏆
d25458a
to
504e74b
Compare
504e74b
to
fb54367
Compare
During update on save, the expected value for the multiprice is the map itself and not the CSV format for the multiprice. In addition, we should avoid sending a "" as multiprice because it causes problems in doofAPI.
07e5c23
to
c82c679
Compare
NOTA: La función getMultiprice()
produce el formato temporal acordado
price_EUR=33/sale_price_EUR=25/price_GBP=11...
para el campodf_multiprice
.