Skip to content

Merge pull request #14 from integer32llc/wtf #25

Merge pull request #14 from integer32llc/wtf

Merge pull request #14 from integer32llc/wtf #25

Triggered via push July 23, 2024 09:12
Status Success
Total duration 51s
Artifacts

rust.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
manual implementation of `BuildHasher::hash_one`: src/bloom.rs#L273
warning: manual implementation of `BuildHasher::hash_one` --> src/bloom.rs:273:9 | 273 | / hasher 274 | | .finish() | |_____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_hash_one help: try | 270 ~ 271 ~ 272 | 273 ~ self.hasher.hash_one(&data) |
manual implementation of `BuildHasher::hash_one`: src/bloom.rs#L256
warning: manual implementation of `BuildHasher::hash_one` --> src/bloom.rs:256:9 | 256 | / hasher 257 | | .finish() | |_____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_hash_one = note: `#[warn(clippy::manual_hash_one)]` on by default help: try | 251 ~ 252 ~ 253 | 254 | // Split the u64 hash into several smaller values to use as unique 255 | // indexes in the bitmap. 256 ~ self.hasher.hash_one(&data) |
casting integer literal to `usize` is unnecessary: src/bloom.rs#L134
warning: casting integer literal to `usize` is unnecessary --> src/bloom.rs:134:5 | 134 | (2 as usize).pow(8 * k as u32) | ^^^^^^^^^^^^ help: try: `2_usize` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
casting to the same type is unnecessary (`usize` -> `usize`): src/bitmap/compressed_bitmap.rs#L247
warning: casting to the same type is unnecessary (`usize` -> `usize`) --> src/bitmap/compressed_bitmap.rs:247:25 | 247 | self.bitmap[offset as usize] &= !bitmask_for_key(key); | ^^^^^^^^^^^^^^^ help: try: `offset` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
casting to the same type is unnecessary (`usize` -> `usize`): src/bitmap/compressed_bitmap.rs#L245
warning: casting to the same type is unnecessary (`usize` -> `usize`) --> src/bitmap/compressed_bitmap.rs:245:25 | 245 | self.bitmap[offset as usize] |= bitmask_for_key(key); | ^^^^^^^^^^^^^^^ help: try: `offset` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `#[warn(clippy::unnecessary_cast)]` on by default
slow zero-filling initialization: src/bitmap/compressed_bitmap.rs#L69
warning: slow zero-filling initialization --> src/bitmap/compressed_bitmap.rs:69:9 | 68 | let mut block_map = Vec::new(); | ---------- help: consider replacing this with: `vec![0; num_blocks]` 69 | block_map.resize(num_blocks, 0); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization = note: `#[warn(clippy::slow_vector_initialization)]` on by default
clippy_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
clippy_check
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/