Give // the same binaryop whitespace exception as ^
#288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickrobinson251
commented
Sep 12, 2020
| CSTParser.RationalOp, | ||
| CSTParser.PowerOp, | ||
| CSTParser.DeclarationOp, | ||
| CSTParser.DotOp, |
There was a problem hiding this comment.
I changed (8, 13, 14, 16) -> (CSTParser.ColonOp, CSTParser.PowerOp, CSTParser.DeclarationOp, CSTParser.DotOp) since it took me quite a while to work out what these mystery numbers were. I think the additional verbosity is worth it. Then i've added RationalOp to catch the // case.
domluna
approved these changes
Sep 13, 2020
domluna
added a commit
that referenced
this pull request
Sep 23, 2020
domluna
added a commit
that referenced
this pull request
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #283, BlueStyle recommends exempting both
^and//from the rule that binary operators are surrounded by whitespace.a ^ bis already formatted asa^b. This PR adds the analogous formattingx // y->x//y.Since
x//yis a singleRationalnumber, i think this makes sense as a general rule, so i've added it to the DefaultStyle - does that seem reasonable?This is my first attempt at making contributions to the code in the package, so please let me know if this approach seems right 😄 Hopefully tests show the intended behaviour