Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add rel to fontTable #2800

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

YousefED
Copy link
Contributor

closes #2521

After this change, I think custom embedded fonts are working.

One feature that still seems to be missing is that docxjs only allows for "regular" fonts to be embedded, i.e. afaik it's not possible to create embeds of different variants like this:

<w:embedRegular r:id="rId3" w:fontKey="{ED927D51-56FC-1C41-961F-307024631508}" />
        <w:embedBold r:id="rId4" w:fontKey="{D6B4F25E-1ACA-814F-AD3C-35D85CD7A6D5}" />
        <w:embedItalic r:id="rId5" w:fontKey="{E5B26720-9505-4B41-AB02-5860705B4C01}" />

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2381ba8) to head (5476a57).

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2800   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          281       281           
  Lines        14093     14099    +6     
  Branches      1381      1381           
=========================================
+ Hits         14093     14099    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Couple issues with embedded fonts
1 participant