Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #2082 Numbering instance restart number not work since v8.0.0 and work well in v7.8.2 #2397

Merged
merged 3 commits into from
Oct 26, 2023

Conversation

hom
Copy link
Contributor

@hom hom commented Oct 26, 2023

Hi, I found this bug #2082 some days ago and I fixed it now.

With addination info, It caused at commit 29da523.

With this commit, I remove @esbuild/win32-x64 dependency, the reason is it causesnpm install failed in my macbook pro, and it is depended with esbuild but not this docx package.

The numbering restart count as normaly after I patched the overrideLevel option
It is the 29 demo result below 👇
image

I will fix as soon if this pr has any problem.

@hom
Copy link
Contributor Author

hom commented Oct 26, 2023

Why the workflow status is Action required

@hom
Copy link
Contributor Author

hom commented Oct 26, 2023

Please see this workflows awaiting approval

@hom
Copy link
Contributor Author

hom commented Oct 26, 2023

To help prevent this, workflows on pull requests to public repositories from some outside contributors will not run automatically, and might need to be approved first. By default, all first-time contributors require approval to run workflows.

By default, all first-time contributors require approval to run workflows., It's my first time to pr this repository: docx

@dolanmiu
Copy link
Owner

Running it now, works now

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f9d1c19) 99.93% compared to head (3d6ead0) 99.93%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2397   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files         329      329           
  Lines       13156    13157    +1     
  Branches     1365     1364    -1     
=======================================
+ Hits        13148    13149    +1     
  Misses          8        8           
Files Coverage Δ
src/file/numbering/numbering.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolanmiu dolanmiu merged commit 1fa8c7a into dolanmiu:master Oct 26, 2023
9 checks passed
@dolanmiu
Copy link
Owner

Thank you, merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants