Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix negative columns in shellcheck output #461

Merged
merged 1 commit into from
Nov 23, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tested/languages/bash/linter.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,13 +84,15 @@
start_col = shellcheck_object.get("column", 1)
end_col = shellcheck_object.get("endColumn")
cols = end_col - start_col if end_col else None
if cols and cols < 1:
cols = 1

Check warning on line 88 in tested/languages/bash/linter.py

View check run for this annotation

Codecov / codecov/patch

tested/languages/bash/linter.py#L88

Added line #L88 was not covered by tests
annotations.append(
AnnotateCode(
row=start_row + config.source_offset,
rows=rows,
text=text,
externalUrl=external,
column=start_col,
column=start_col - 1,
columns=cols,
type=message_categories.get(
shellcheck_object.get("level", "warning"), Severity.WARNING
Expand Down
Loading