Update Java from 17 to 21 #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chvp
reviewed
Feb 13, 2024
| @@ -1,13 +1,13 @@ | |||
| FROM openjdk:17-slim | |||
| FROM eclipse-temurin:21-jdk-alpine | |||
There was a problem hiding this comment.
Is there a Debian slim base? Most of our other docker images are (indirectly) based on debian slim, so it should result in space saved if we can use that here as well.
There was a problem hiding this comment.
Unfortunately their slim images are Ubuntu-based. So I don't think we can share there.
chvp
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Java version to 21 and switches the used base image to
eclipse-temurin:21-jdk-alpineShould be coordinated with dodona-edu/judge-java#60