Backport UPGRADE-5.0 #827
Merged
Backport UPGRADE-5.0 #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To me it's easier this way. In one PR you can introduce
Othwrwise "killing notes" would need to be done retroactively upon major release. |
|
Ah never mind, just saw what Symfony is doing. I'm quite OK with that :) |
|
What's better? Update it or remove it? In case of update, I'll take #828 changes. |
GromNaN
force-pushed
the
backport-upgrade-5
branch
from
d057d04 to
ffdbbae
Compare
alcaeus
approved these changes
Dec 22, 2023
|
I'm fine with both - whatever is less friction TBH. |
|
I'm fine with what Symfony does 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure why we maintain this file in the previous branch. We decided to no longer do that in Symfony (see UPGRADE-7.0 on branch 6.4)