Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix in README.md #35

Merged
merged 2 commits into from
Oct 27, 2024
Merged

Small fix in README.md #35

merged 2 commits into from
Oct 27, 2024

Conversation

ineiti
Copy link
Contributor

@ineiti ineiti commented Oct 27, 2024

Actually not sure if this is correct - but the only other occurence of sigPk is a BBSPlusPublicKeyG2. At least it looks wrong to have the sigPk be of type BBSPlusSecretKey...

Actually not sure if this is correct - but the only other occurence of `sigPk` is a `BBSPlusPublicKeyG2`. At least it looks wrong to have the `sigPk` be of type `BBSPlusSecretKey`...
@lovesh
Copy link
Member

lovesh commented Oct 27, 2024

Yes, you're change is correct.
Secondly, some of the functions shown in the readme have changed, see this for an example. Until this gets updated, have a look at these tests.

@lovesh lovesh merged commit 34f6d3b into docknetwork:master Oct 27, 2024
12 checks passed
@ineiti
Copy link
Contributor Author

ineiti commented Oct 28, 2024

@lovesh #33 is from my colleague. I told him to look at how to improve the documentation a bit... Any pointers in what you think is the most important part?

We're using the library for one of our hands-on workshops, and the library is really great - incredible work! If we can contribute with some documentation, we'd be happy.

@lovesh
Copy link
Member

lovesh commented Oct 28, 2024

Thanks for your offer to help.
The conceptual documentation is fine. But some of the code examples are out of date so they need to be fixed by looking at the tests I mentioned before. Secondly there are some new features added like more protocols for range proofs which you can see in these tests but missing in the Readme.
The API described in the Readme is low-level and a higher level abstraction exists and is documented here conceptually but lacks code examples which could be written referring these tests, mostly this one. If you haven't seen this abstraction, I'll suggest taking a look. Its more ergonomic than the code examples in the main Readme.
There is support for threshold BBS/BBS+ as seen in this test but missing from Readme.
Finally, which parts have you had trouble using and think could benefit from more documentation, tests or a better API

@ineiti
Copy link
Contributor Author

ineiti commented Oct 29, 2024

Great - thanks a lot. I'll discuss it with @lanterno and come back to you. Is there already an issue regarding documentation?

@lovesh lovesh mentioned this pull request Oct 29, 2024
@lovesh
Copy link
Member

lovesh commented Oct 29, 2024

Thanks. Just created this issue. Feel free to ask any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants